----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31711/#review75115 -----------------------------------------------------------
Thanks for the patch. A comment below. core/src/main/scala/kafka/utils/ZkUtils.scala <https://reviews.apache.org/r/31711/#comment122059> Since we may be calling the methods on ZkPath from different threads, we will need to make isNameSpaceChecked volatile. - Jun Rao On March 4, 2015, 12:45 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31711/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 12:45 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1994 > https://issues.apache.org/jira/browse/KAFKA-1994 > > > Repository: kafka > > > Description > ------- > > KAFKA-1994: Evaluate performance effect of chroot check on Topic creation > > > Diffs > ----- > > core/src/main/scala/kafka/utils/ZkUtils.scala > 7ae999ec619443d35a9cb8fbcd531fca0c51c8c0 > core/src/test/scala/unit/kafka/zk/ZKPathTest.scala > 9897b2fa8f8261fe8ab6b62b45b9052adb07043f > > Diff: https://reviews.apache.org/r/31711/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
