-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30126/
-----------------------------------------------------------
(Updated March 4, 2015, 11:12 p.m.)
Review request for kafka.
Bugs: KAFKA-1845
https://issues.apache.org/jira/browse/KAFKA-1845
Repository: kafka
Description (updated)
-------
KAFKA-1845 - Fixed merge conflicts, ported added configs to KafkaConfig
KAFKA-1845 - KafkaConfig to ConfigDef: moved validateValues so it's called on
instantiating KafkaConfig
KAFKA-1845 - KafkaConfig to ConfigDef: MaxConnectionsPerIpOverrides refactored
KAFKA-1845 - code review fixes, merge conflicts after rebase
KAFKA-1845 - rebase to trunk
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
8523333a9b39a2f9cd71d176943be86531a43ede
core/src/main/scala/kafka/Kafka.scala
77a49e12af6f869e63230162e9f87a7b0b12b610
core/src/main/scala/kafka/controller/KafkaController.scala
e9b4dc62df3f139de8d4dc688e48ccc0a5513123
core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala
4a31c7271c2d0a4b9e8b28be729340ecfa0696e5
core/src/main/scala/kafka/server/KafkaConfig.scala
14bf3216bae030331bdf76b3266ed0e73526c3de
core/src/main/scala/kafka/server/KafkaServer.scala
8e3def9e9edaf49c0443a2e08cf37277d0f25306
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
6879e730282185bda3d6bc3659cb15af0672cecf
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
5650b4a7b950b48af3e272947bfb5e271c4238c9
core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala
e63558889272bc76551accdfd554bdafde2e0dd6
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
d34ee3a40dcc8475e183435ad6842cd3d0a13ade
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala
8154a4210dc8dcceb26549c98bbbc4a1282a1c67
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
1bf2667f47853585bc33ffb3e28256ec5f24ae84
core/src/test/scala/unit/kafka/admin/AdminTest.scala
e28979827110dfbbb92fe5b152e7f1cc973de400
core/src/test/scala/unit/kafka/admin/DeleteConsumerGroupTest.scala
d530338728be41282925b3a62030d1f316b4f9c5
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
c8f336aa034ab5702c7644a669fd32c746512d29
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala
c0355cc0135c6af2e346b4715659353a31723b86
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
a17e8532c44aadf84b8da3a57bcc797a848b5020
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala
95303e098d40cd790fb370e9b5a47d20860a6da3
core/src/test/scala/unit/kafka/integration/FetcherTest.scala
25845abbcad2e79f56f729e59239b738d3ddbc9d
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala
aeb7a19acaefabcc161c2ee6144a56d9a8999a81
core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala
eab4b5f619015af42e4554660eafb5208e72ea33
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
35dc071b1056e775326981573c9618d8046e601d
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
ba3bcdcd1de9843e75e5395dff2fc31b39a5a9d5
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala
d6248b09bb0f86ee7d3bd0ebce5b99135491453b
core/src/test/scala/unit/kafka/log/LogTest.scala
1a4be70a21fe799d4d71dd13e84968e40fb8ad92
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala
4ea0489c9fd36983fe190491a086b39413f3a9cd
core/src/test/scala/unit/kafka/metrics/MetricsTest.scala
111e4a26c1efb6f7c151ca9217dbe107c27ab617
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala
1db6ac329f7b54e600802c8a623f80d159d4e69b
core/src/test/scala/unit/kafka/producer/ProducerTest.scala
ce65dab4910d9182e6774f6ef1a7f45561ec0c23
core/src/test/scala/unit/kafka/producer/SyncProducerTest.scala
d60d8e0f49443f4dc8bc2cad6e2f951eda28f5cb
core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala
f0c4a56b61b4f081cf4bee799c6e9c523ff45e19
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala
ad121169a5e80ebe1d311b95b219841ed69388e2
core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
8913fc1d59f717c6b3ed12c8362080fb5698986b
core/src/test/scala/unit/kafka/server/ISRExpirationTest.scala
a703d2715048c5602635127451593903f8d20576
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
82dce80d553957d8b5776a9e140c346d4e07f766
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
core/src/test/scala/unit/kafka/server/LogOffsetTest.scala
c06ee756bf0fe07e5d3c92823a476c960b37afd6
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala
d5d351c4f25933da0ba776a6a89a989f1ca6a902
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
a37a74dc89edca0c03150db17ee9dff1dac15606
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala
da4bafc1e2a94a436efe395aab1888fc21e55748
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
d1ed5c2c506898c2978860a0ec6f6767d42370a0
core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala
cf2dd9455a9198b7215468df9f29568e91b31850
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
82fa4cff45043e74825c12f3c8494fa8fc903334
core/src/test/scala/unit/kafka/server/ServerStartupTest.scala
93af7dfcec7a6b1c1adfbe278d30d8406a84b60d
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
fd8f32c4158d44cb13ec7f27de11ee60aca49fd9
core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala
305498adf416a46d59e5c266f3417a38f529be2d
Diff: https://reviews.apache.org/r/30126/diff/
Testing
-------
Thanks,
Andrii Biletskyi
