> On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/PartitionAssignor.scala, line 74 > > <https://reviews.apache.org/r/31706/diff/4/?file=885021#file885021line74> > > > > Why does this need to be a pool? i.e., rebalance is done while holding > > a lock.
It doesn't have to be. But so we can use the methods it provided like getAndMaybePut. It makes code cleaner. > On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 727 > > <https://reviews.apache.org/r/31706/diff/4/?file=885022#file885022line727> > > > > Rather build out the val here, can you move this to a separate line > > above? > > > > Also, we can call it globalPartitionAssignment It is actually different from the globalPartitionAssignment returned by assignor. I changed the name to partitionAssigmentMapForCallback. > On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line > > 729 > > <https://reviews.apache.org/r/31706/diff/4/?file=885022#file885022line729> > > > > partitionOwnerships -> topicPartitionAssignment I don't quite get this. Can you elaborate? > On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 241 > > <https://reviews.apache.org/r/31706/diff/4/?file=885024#file885024line241> > > > > Why was this change made? It is to avoid that consumer blocks on a low volume pipeline and not able to commit offsets. Just like the timeout for new consumer's poll(). > On March 6, 2015, 12:14 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 310 > > <https://reviews.apache.org/r/31706/diff/4/?file=885024#file885024line310> > > > > how does the user override? Good catch! - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31706/#review75409 ----------------------------------------------------------- On March 6, 2015, 4:15 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31706/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 4:15 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1997 > https://issues.apache.org/jira/browse/KAFKA-1997 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Changed the exit behavior on send failure because close(0) is not ready yet. > Will submit followup patch after KAFKA-1660 is checked in. > > > Expanded imports from _ and * to full class path > > > Incorporated Joel's comments. > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > d5c79e2481d5e9a2524ac2ef6a6879f61cb7cb5f > core/src/main/scala/kafka/consumer/PartitionAssignor.scala > e6ff7683a0df4a7d221e949767e57c34703d5aad > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 5487259751ebe19f137948249aa1fd2637d2deb4 > core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java > 7f45a90ba6676290172b7da54c15ee5dc1a42a2e > core/src/main/scala/kafka/tools/MirrorMaker.scala > 5374280dc97dc8e01e9b3ba61fd036dc13ae48cb > core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala > 543070f4fd3e96f3183cae9ee2ccbe843409ee58 > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > a17e8532c44aadf84b8da3a57bcc797a848b5020 > > Diff: https://reviews.apache.org/r/31706/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
