> On March 11, 2015, 5:06 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 97 > > <https://reviews.apache.org/r/31927/diff/1/?file=891131#file891131line97> > > > > How about making the default 1000 ms?
On a second thought I think we should put a longer backoff as the default. Most of the users won't override all of these configs so having a 1 sec here doesn't help much if the ReplicaFetcherThread encountering any errors. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31927/#review76075 ----------------------------------------------------------- On March 11, 2015, 5:41 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31927/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 5:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1461 > https://issues.apache.org/jira/browse/KAFKA-1461 > > > Repository: kafka > > > Description > ------- > > KAFKA-1461. Replica fetcher thread does not implement any back-off behavior. > > > Diffs > ----- > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 8c281d4668f92eff95a4a5df3c03c4b5b20e7095 > core/src/main/scala/kafka/server/KafkaConfig.scala > 48e33626695ad8a28b0018362ac225f11df94973 > core/src/main/scala/kafka/server/ReplicaFetcherThread.scala > d6d14fbd167fb8b085729cda5158898b1a3ee314 > core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala > c124c8df5b5079e5ffbd0c4ea359562a66aaf317 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 52c79201af7c60f9b44a0aaa09cdf968d89a7b87 > > Diff: https://reviews.apache.org/r/31927/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
