----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31830/#review76145 -----------------------------------------------------------
Ship it! Ship It! - Onur Karaman On March 11, 2015, 6:26 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31830/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 6:26 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2009 > https://issues.apache.org/jira/browse/KAFKA-2009 > > > Repository: kafka > > > Description > ------- > > Because the send callback could be fired in producer.send() as well, so > unacked offset needs to be added to unacked offsets list before call > producer.send() > > > Diffs > ----- > > core/src/main/scala/kafka/tools/MirrorMaker.scala > bafa379ff57bc46458ea8409406f5046dc9c973e > > Diff: https://reviews.apache.org/r/31830/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
