[ 
https://issues.apache.org/jira/browse/KAFKA-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378236#comment-14378236
 ] 

Gwen Shapira commented on KAFKA-1927:
-------------------------------------

The uploaded patch is:
1. Preliminary and untested, just to show what I had in mind. 
2. Actually belongs in KAFKA-2044...

> Replace requests in kafka.api with requests in 
> org.apache.kafka.common.requests
> -------------------------------------------------------------------------------
>
>                 Key: KAFKA-1927
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1927
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jay Kreps
>            Assignee: Gwen Shapira
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-1927.patch
>
>
> The common package introduced a better way of defining requests using a new 
> protocol definition DSL and also includes wrapper objects for these.
> We should switch KafkaApis over to use these request definitions and consider 
> the scala classes deprecated (we probably need to retain some of them for a 
> while for the scala clients).
> This will be a big improvement because
> 1. We will have each request now defined in only one place (Protocol.java)
> 2. We will have built-in support for multi-version requests
> 3. We will have much better error messages (no more cryptic underflow errors)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to