----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32434/#review77634 -----------------------------------------------------------
As discussed offline, I think it is better to make the fix in the app-level (KafkaProducer, Metadata) rather than forbidding sending emptry MetadataRequest in NetworkClient. - Guozhang Wang On March 24, 2015, 8:17 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32434/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 8:17 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2042 > https://issues.apache.org/jira/browse/KAFKA-2042 > > > Repository: kafka > > > Description > ------- > > Patch for KAFKA-2042. Do not update metadata for empty topic set in new > producer > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/NetworkClient.java > f4295025c28e2842244dc775052b7a3d30fb9d11 > > Diff: https://reviews.apache.org/r/32434/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
