[
https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379451#comment-14379451
]
Ewen Cheslack-Postava commented on KAFKA-1501:
----------------------------------------------
[~guozhang] Sorry, seems I missed your review comments on the last patch. I've
addressed most of them and rebased to currrent trunk. Also had to make some
changes to handle the consumer tests that were added back. And I restored the
test I commented to use the previous port allocation strategy so we still get
test coverage while minimizing (but not entirely eliminating) tests that can
fail due to ports already in use.
We now have 2 places where we need fixed ports to properly handle tests --
bounce tests for the new producer and new consumer implementations. Both are
integration tests that probably better to have in a separate integration tests
framework. But until we have a better solution than the existing system test
framework, it probably does make sense to fix the majority of tests. A few can
still fail, but at least we'll have drastically reduced the probability of
encountering this error.
> transient unit tests failures due to port already in use
> --------------------------------------------------------
>
> Key: KAFKA-1501
> URL: https://issues.apache.org/jira/browse/KAFKA-1501
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Reporter: Jun Rao
> Assignee: Guozhang Wang
> Labels: newbie
> Attachments: KAFKA-1501-choosePorts.patch, KAFKA-1501.patch,
> KAFKA-1501.patch, KAFKA-1501.patch, KAFKA-1501.patch,
> KAFKA-1501_2015-03-09_11:41:07.patch, KAFKA-1501_2015-03-25_00:44:50.patch,
> test-100.out, test-100.out, test-27.out, test-29.out, test-32.out,
> test-35.out, test-38.out, test-4.out, test-42.out, test-45.out, test-46.out,
> test-51.out, test-55.out, test-58.out, test-59.out, test-60.out, test-69.out,
> test-72.out, test-74.out, test-76.out, test-84.out, test-87.out, test-91.out,
> test-92.out
>
>
> Saw the following transient failures.
> kafka.api.ProducerFailureHandlingTest > testTooLargeRecordWithAckOne FAILED
> kafka.common.KafkaException: Socket server failed to bind to
> localhost:59909: Address already in use.
> at kafka.network.Acceptor.openServerSocket(SocketServer.scala:195)
> at kafka.network.Acceptor.<init>(SocketServer.scala:141)
> at kafka.network.SocketServer.startup(SocketServer.scala:68)
> at kafka.server.KafkaServer.startup(KafkaServer.scala:95)
> at kafka.utils.TestUtils$.createServer(TestUtils.scala:123)
> at
> kafka.api.ProducerFailureHandlingTest.setUp(ProducerFailureHandlingTest.scala:68)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
