----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review77732 -----------------------------------------------------------
bin/kafka-run-class.sh <https://reviews.apache.org/r/30809/#comment125922> Probably a leftover debug print. core/src/main/scala/kafka/tools/ContinuousValidationTest.java <https://reviews.apache.org/r/30809/#comment125923> Not sure if this belongs to tools package. Any specific reason why we cannot use existing producer consumer tests' variants? Can they be extended to avoid creating yet another producer consumer test? system_test/broker_upgrade/bin/test-broker-upgrade.sh <https://reviews.apache.org/r/30809/#comment125924> Relying on greps for validation is probably not the best way. system_test/broker_upgrade/bin/test-broker-upgrade.sh <https://reviews.apache.org/r/30809/#comment125925> Probably, extract out in a "upgrade" method for reusability and readability. - Ashish Singh On March 23, 2015, 6:54 p.m., Abhishek Nigam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30809/ > ----------------------------------------------------------- > > (Updated March 23, 2015, 6:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1888 > https://issues.apache.org/jira/browse/KAFKA-1888 > > > Repository: kafka > > > Description > ------- > > Updated the RB with Gwen's comments, Beckett's comments and a subset of > Guozhang's comments > > > Diffs > ----- > > bin/kafka-run-class.sh 881f578a8f5c796fe23415b978c1ad35869af76e > core/src/main/scala/kafka/tools/ContinuousValidationTest.java PRE-CREATION > core/src/main/scala/kafka/utils/ShutdownableThread.scala > fc226c863095b7761290292cd8755cd7ad0f155c > system_test/broker_upgrade/bin/test-broker-upgrade.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/30809/diff/ > > > Testing > ------- > > Scripted it to run 20 times without any failures. > Command-line: broker-upgrade/bin/test.sh <dir1> <dir2> > > > Thanks, > > Abhishek Nigam > >
