> On March 25, 2015, 9:43 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java, > > lines 46-54 > > <https://reviews.apache.org/r/32459/diff/1/?file=904768#file904768line46> > > > > Instead of adding this method here, would it be better to add it to an > > abstract subclass AbstractRequest? All requests will now to a subclass of > > AbstractRequest and they will be forced to implement this method. > > Gwen Shapira wrote: > This means adding a handleError to all Requests in this patch (even > though the method will not be used until the request is actually used within > KafkaApis). > If you think its safer (and I agree it may be), I'll go ahead and do this.
Yes, it does mean that we will add this method to all existing requests. I think this makes the code a bit cleaner and safer. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32459/#review77805 ----------------------------------------------------------- On March 24, 2015, 10:39 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32459/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 10:39 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2044 > https://issues.apache.org/jira/browse/KAFKA-2044 > > > Repository: kafka > > > Description > ------- > > support requests and responses using Common api in core modules (missing > files) > > > added error handling and factory method for requests > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/requests/AbstractRequestResponse.java > 37aff6c0fd2ec2da8551aa74b166ca49b224ddd3 > > clients/src/main/java/org/apache/kafka/common/requests/HeartbeatRequest.java > 6943878116a97c02b758d273d93976019688830e > > clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java > 1ebc188742fd65e5e744003b4579324874fd81a9 > core/src/main/scala/kafka/api/HeartbeatRequestAndHeader.scala > f168d9fc99ce51b8b41b7f7db2a06f371b1a44e5 > core/src/main/scala/kafka/api/HeartbeatResponseAndHeader.scala > 9a71faae3138af1b4fb48125db619ddc3ad13c5a > core/src/main/scala/kafka/api/JoinGroupRequestAndHeader.scala > 3651e8603dd0ed0d2ea059786c68cf0722aa094b > core/src/main/scala/kafka/api/JoinGroupResponseAndHeader.scala > d0f07e0cbbdacf9ff8287e901ecabde3921bbab3 > core/src/main/scala/kafka/api/RequestKeys.scala > c24c0345feedc7b9e2e9f40af11bfa1b8d328c43 > core/src/main/scala/kafka/network/BoundedByteBufferSend.scala > 55ecac285e00abf38d7131368bb46b4c4010dc87 > core/src/main/scala/kafka/network/RequestChannel.scala > 7b1db3dbbb2c0676f166890f566c14aa248467ab > core/src/main/scala/kafka/server/KafkaApis.scala > 35af98f0bc1b6a50bd1d97a30147593f8c6a422d > core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala > fba852afa1b2f46b61e2fd12c38c821ba04e9cc6 > > Diff: https://reviews.apache.org/r/32459/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
