[ https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396077#comment-14396077 ]
Gwen Shapira commented on KAFKA-1809: ------------------------------------- Quick summary of changes since [~jjkoshy] and [~junrao] review: 0. Removed SecurityProtocol from core 1. I noticed that I was not using security.protocol configuration on the clients at all (even when testing upgrades), so I removed it 2. Registration to ZK failed if brokers were not configured with PLAINTEXT protocol. Fixed this. Of course ZK consumers will not work in this state. 3. Following KAFKA-1501, I changed the way Processors figure out which security protocol is used. I sent an email to mailing list explaining the new logic. 4. Also modified EndPoint to parse connection strings with negative port numbers, since those are used in some tests > Refactor brokers to allow listening on multiple ports and IPs > -------------------------------------------------------------- > > Key: KAFKA-1809 > URL: https://issues.apache.org/jira/browse/KAFKA-1809 > Project: Kafka > Issue Type: Sub-task > Components: security > Reporter: Gwen Shapira > Assignee: Gwen Shapira > Attachments: KAFKA-1809-DOCs.V1.patch, KAFKA-1809.patch, > KAFKA-1809.v1.patch, KAFKA-1809.v2.patch, KAFKA-1809.v3.patch, > KAFKA-1809_2014-12-25_11:04:17.patch, KAFKA-1809_2014-12-27_12:03:35.patch, > KAFKA-1809_2014-12-27_12:22:56.patch, KAFKA-1809_2014-12-29_12:11:36.patch, > KAFKA-1809_2014-12-30_11:25:29.patch, KAFKA-1809_2014-12-30_18:48:46.patch, > KAFKA-1809_2015-01-05_14:23:57.patch, KAFKA-1809_2015-01-05_20:25:15.patch, > KAFKA-1809_2015-01-05_21:40:14.patch, KAFKA-1809_2015-01-06_11:46:22.patch, > KAFKA-1809_2015-01-13_18:16:21.patch, KAFKA-1809_2015-01-28_10:26:22.patch, > KAFKA-1809_2015-02-02_11:55:16.patch, KAFKA-1809_2015-02-03_10:45:31.patch, > KAFKA-1809_2015-02-03_10:46:42.patch, KAFKA-1809_2015-02-03_10:52:36.patch, > KAFKA-1809_2015-03-16_09:02:18.patch, KAFKA-1809_2015-03-16_09:40:49.patch, > KAFKA-1809_2015-03-27_15:04:10.patch, KAFKA-1809_2015-04-02_15:12:30.patch, > KAFKA-1809_2015-04-02_19:03:58.patch, KAFKA-1809_2015-04-04_22:00:13.patch > > > The goal is to eventually support different security mechanisms on different > ports. > Currently brokers are defined as host+port pair, and this definition exists > throughout the code-base, therefore some refactoring is needed to support > multiple ports for a single broker. > The detailed design is here: > https://cwiki.apache.org/confluence/display/KAFKA/Multiple+Listeners+for+Kafka+Brokers -- This message was sent by Atlassian JIRA (v6.3.4#6332)