-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32942/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1688
https://issues.apache.org/jira/browse/KAFKA-1688
Repository: kafka
Description
-------
This is still a draft version and I am working on making the code "more scala
less java". There are a few TODOs some of which are dependent on other jiras
some are notes to my self. I am posting the review to get early feedback on
clear red-flags.
KAFKA-1688: Add authorization.
Diffs
-----
core/src/main/scala/kafka/admin/AdminUtils.scala
eee80f9c2c12da8e4879e96785f3b75a8ff7d1cd
core/src/main/scala/kafka/admin/TopicCommand.scala
60f0228e6735a492315842afe28bcfa317478968
core/src/main/scala/kafka/api/TopicMetadata.scala
5e39f453b429cb42ab87f695b6b30576f9ce98ce
core/src/main/scala/kafka/common/AuthorizationException.scala PRE-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala
eb1eb4a703098253d0aae79577084569177768d1
core/src/main/scala/kafka/log/LogConfig.scala
558c703f26da22b1a938bbbf8a6c4409a8e107fb
core/src/main/scala/kafka/network/RequestChannel.scala
1d9c57b0b5a0ad31e4f3d7562f0266af83cc9024
core/src/main/scala/kafka/security/auth/Acl.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/Authorizer.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/ClusterAclCache.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/Operation.java PRE-CREATION
core/src/main/scala/kafka/security/auth/PermissionType.java PRE-CREATION
core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala
PRE-CREATION
core/src/main/scala/kafka/server/KafkaApis.scala
b4004aa3a1456d337199aa1245fb0ae61f6add46
core/src/main/scala/kafka/server/KafkaConfig.scala
69b772c1941865fbe15b34bb2784c511f8ce519a
core/src/main/scala/kafka/server/KafkaServer.scala
c63f4ba9d622817ea8636d4e6135fba917ce085a
core/src/main/scala/kafka/server/MetadataCache.scala
9a9205f78ff208a8103650dc8ea958ce59b7b507
core/src/main/scala/kafka/server/TopicConfig.scala PRE-CREATION
core/src/main/scala/kafka/server/TopicConfigCache.scala PRE-CREATION
core/src/main/scala/kafka/server/TopicConfigManager.scala
47295d40131492aaac786273819b7bc6e22e5486
core/src/main/scala/kafka/utils/Json.scala
d1102844748f2e88f79932281fe95583a57d2d16
core/src/test/resources/acl.json PRE-CREATION
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala
ab5d16c1d22191708410b15332882ba40eda5f28
core/src/test/scala/unit/kafka/admin/AdminTest.scala
cfe38df577e3f179ebecad3f45429a15aa69e7b4
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
61cc6028dd7c9a2eec2d9cbe6947764655801eee
core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
c7136f20972614ac47aa57ab13e3c94ef775a4b7
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala
a1300894258c0ee77dffc96df24a2f7369eb68da
core/src/test/scala/unit/kafka/security/auth/AclTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/security/auth/ClusterAclTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/security/auth/SimpleAclAuthorizerTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala
7877f6ca1845c2edbf96d4a9783a07a552db8f07
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala
62d183248e3be4c83d2c768e762f61f92448c6a6
core/src/test/scala/unit/kafka/server/TopicConfigCacheTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/utils/TestUtils.scala
5a9e84d44f6567c3a01a4e068c751edb07ee9634
Diff: https://reviews.apache.org/r/32942/diff/
Testing
-------
Unit tests added for the SimpleACLAuthorizer, ACl and ClusterAclCache. Modified
existing unit tests for TopicCommands and TopicConfigCache.
Thanks,
Parth Brahmbhatt
