[
https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485494#comment-14485494
]
Tim Brooks commented on KAFKA-2102:
-----------------------------------
Thanks for the feedback.
Unless I misunderstand you I think that I fixed number 1 in the updated
patched. Issue number 2 you raised is definitely the kind of feedback I was
looking for. And something that I'll look into.
Generally, I saw pretty reasonable latency improvements in the 90+ percentiles.
Enough that I committed some time to seeing if I could find a workable solution.
I too am concerned about the complexity. I'm hoping to be able to come up with
a solution that is more intuitive (and does not depend on lastRefreshMs never
being 0).
I'll continue to explore this. If I find some way to do this (or part of this)
in a way to provides an noticeable performance improvement, I'll definitely
submit those changes and some benchmark numbers to justify them.
> Remove unnecessary synchronization when managing metadata
> ---------------------------------------------------------
>
> Key: KAFKA-2102
> URL: https://issues.apache.org/jira/browse/KAFKA-2102
> Project: Kafka
> Issue Type: Improvement
> Reporter: Tim Brooks
> Assignee: Tim Brooks
> Attachments: KAFKA-2102.patch, KAFKA-2102_2015-04-08_00:20:33.patch
>
>
> Usage of the org.apache.kafka.clients.Metadata class is synchronized. It
> seems like the current functionality could be maintained without
> synchronizing the whole class.
> I have been working on improving this by moving to finer grained locks and
> using atomic operations. My initial benchmarking of the producer is that this
> will improve latency (using HDRHistogram) on submitting messages.
> I have produced an initial patch. I do not necessarily believe this is
> complete. And I want to definitely produce some more benchmarks. However, I
> wanted to get early feedback because this change could be deceptively tricky.
> I am interested in knowing if this is:
> 1. Something that is of interest to the maintainers/community.
> 2. Along the right track
> 3. If there are any gotchas that make my current approach naive.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
