[
https://issues.apache.org/jira/browse/KAFKA-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492598#comment-14492598
]
Jay Kreps commented on KAFKA-1910:
----------------------------------
Hey [~guozhang],
1. Cool. Yeah I think create is actually also a bit bad though because of the
call to ensureCoordinatorReady which is a big chunk of network I/O work
potentially (create sounds like a pure function). Maybe
readyCoordinatorRequest? That is a bit more neutral.
2. Yeah if you feel like they are separate that makes sense. I guess I just
liked being able to read the request and response together to reason about the
complete request, but this is a pretty minor gripe. I agree that made the
methods very large.
> Refactor KafkaConsumer
> ----------------------
>
> Key: KAFKA-1910
> URL: https://issues.apache.org/jira/browse/KAFKA-1910
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Fix For: 0.8.3
>
> Attachments: KAFKA-1910.patch, KAFKA-1910.patch, KAFKA-1910.patch,
> KAFKA-1910_2015-03-05_14:55:33.patch
>
>
> KafkaConsumer now contains all the logic on the consumer side, making it a
> very huge class file, better re-factoring it to have multiple layers on top
> of KafkaClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
