-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2123
https://issues.apache.org/jira/browse/KAFKA-2123
Repository: kafka
Description
-------
WIP KAFKA-2123: Make new consumer offset commit API use a callback and return a
Future.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
96ac6d0cca990eebe90707465d7d8091c069a4b2
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
b7ae595f2cc46e5dfe728bc3ce6082e9cd0b6d36
clients/src/main/java/org/apache/kafka/clients/consumer/CommitType.java
7548a9ba0163a3c010b909a29a010b408cd0794a
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
8f587bc0705b65b3ef37c86e0c25bb43ab8803de
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerCommitCallback.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
21243345311a106f0802ce96c026ba6e815ccf99
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
f50da825756938c193d7f07bee953e000e2627d9
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitFuture.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
e55ab11df4db0b0084f841a74cbcf819caf780d5
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
cee75410127dd1b86c1156563003216d93a086b3
clients/src/test/java/org/apache/kafka/clients/MockClient.java
5e3fab13e3c02eb351558ec973b949b3d1196085
clients/src/test/java/org/apache/kafka/clients/consumer/MockConsumerTest.java
677edd385f35d4262342b567262c0b874876d25b
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java
b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java
8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
35f4f4612c60e9987e7bedded574d5fc53eba393
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
ffbdf5dc106e2a59563768280074696c76491337
Diff: https://reviews.apache.org/r/33196/diff/
Testing
-------
Thanks,
Ewen Cheslack-Postava
