[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503222#comment-14503222 ]
Jay Kreps commented on KAFKA-2035: ---------------------------------- Hey [~parth.brahmbhatt] I'm not picky about the sequencing as long as it gets done and we don't get left in a half-way state. If you're on-board to take it all the way I think that could be great. But from that point of view, is there a reason we need to set the ACLs at the topic level rather than just having them at the log level? Topic configs are all set at the topic level but stored in memory at the log level today, so I'm not sure if I get why ACLs are different...? An alternative would be to leave it as is and then refactor when we have a plan for how we want it to end up. I think the difference you are pointing out is that logically ACLs don't belong mixed in with the Log data model, right? > Add a topic config cache. > ------------------------- > > Key: KAFKA-2035 > URL: https://issues.apache.org/jira/browse/KAFKA-2035 > Project: Kafka > Issue Type: Task > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > Attachments: KAFKA-2035_2015-03-31_10:52:12.patch > > > Currently the topic config is all about Log configuration so we have a > TopicConfigManager which takes in a Log instance and keeps updating that > instance's config instance as and when the topic config is updated. The topic > config update notifications are sent using zk watchers by Controller. > I propose to introduce a TopicConfigCache which will be updated by > TopicConfigManager on any config changes. The log instance and any other > component (like the authorizer mentioned in KAFKA-1688) will have a reference > to TopicConfigCache using which they will access the topic configs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)