> On April 21, 2015, 3:08 a.m., Guozhang Wang wrote: > > LGTM, besides one minor suggestion: could you move MockMetricsReporter to > > clients/src/test/java/org/apache/kafka/test?
done. moved MockMetricsReporter to clients/src/test/java/org/apache/kafka/test - Steven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33242/#review80892 ----------------------------------------------------------- On April 21, 2015, 5:48 a.m., Steven Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33242/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 5:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2121 > https://issues.apache.org/jira/browse/KAFKA-2121 > > > Repository: kafka > > > Description > ------- > > move MockMetricsReporter into clients/src/test/java/org/apache/kafka/test > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/ClientUtils.java > d0da5d7a08a0c3e67e0fe14bb0b0e7c73380f416 > clients/src/main/java/org/apache/kafka/clients/KafkaClient.java > 96ac6d0cca990eebe90707465d7d8091c069a4b2 > clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java > 21243345311a106f0802ce96c026ba6e815ccf99 > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > b91e2c52ed0acb1faa85915097d97bafa28c413a > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 70954cadb5c7e9a4c326afcf9d9a07db230e7db2 > clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java > b3d3d7c56acb445be16a3fbe00f05eaba659be46 > > clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java > 13be6a38cb356d55e25151776328a3c38c573db4 > clients/src/main/java/org/apache/kafka/common/serialization/Serializer.java > c2fdc23239bd2196cd912c3d121b591f21393eab > > clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java > PRE-CREATION > clients/src/test/java/org/apache/kafka/test/MockMetricsReporter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33242/diff/ > > > Testing > ------- > > > Thanks, > > Steven Wu > >
