-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32937/
-----------------------------------------------------------
(Updated April 27, 2015, 12:26 a.m.)
Review request for kafka.
Bugs: KAFKA-2102
https://issues.apache.org/jira/browse/KAFKA-2102
Repository: kafka
Description (updated)
-------
Method does not need to be synchronized
Do not synchronize contains topic method
Continue removing the need to synchronize the metadata object
Store both last refresh and need to refresh in same variable
Fix synchronize issue
Version needs to be volatile
rework how signally happens
remove unnecessary creation of new set
initialize 0 at the field level
Fix the build
Start moving synchronization of metadata to different class
Start moving synchronization work to new class
Remove unused code
Functionality works. Not threadsafe
move version into metadata synchronizer
Make version volatile
Rename classes
move to finergrained locking
Use locks in bookkeeper
Only use atomic variabled
use successful metadata in metrics
Change these things back to trunk
Address issues with patch
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/Metadata.java
07f1cdb1fe920b0c7a5f2d101ddc40c689e1b247
clients/src/main/java/org/apache/kafka/clients/MetadataBookkeeper.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
b7ae595f2cc46e5dfe728bc3ce6082e9cd0b6d36
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
42b12928781463b56fc4a45d96bb4da2745b6d95
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
b2db91ca14bbd17fef5ce85839679144fff3f689
Diff: https://reviews.apache.org/r/32937/diff/
Testing
-------
Thanks,
Tim Brooks
