[ 
https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513614#comment-14513614
 ] 

ASF GitHub Bot commented on KAFKA-1054:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/57

    KAFKA-1054; Eliminate Scala Compilation Warnings

    Changes:
    - Suppressed compiler warnings about type erasure in matching via unboxing
    by Jon Riehl.
    - Suppressed warning caused by slight difference in input function type
    by John Riehl.
    - Fix compiler warnings: ServerShutdownTest, DelayedJoinGroup function
    signature by Blake Smith.
    - Fix Scala 2.11 warnings. `Pair` has been deprecated, `try` without
    `catch` and `finally` is useless and initialisation order fix by Ismael
    Juma.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-1054-squashed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 0a5501c84208ea2cb734cc2c2e30735503716f32
Author: Jon Riehl <jri...@spaceship.com>
Date:   2014-09-05T23:25:32Z

    KAFKA-1054; Eliminate Scala Compilation Warnings
    
    Changes:
    - Suppressed compiler warnings about type erasure in matching via unboxing
    by Jon Riehl.
    - Suppressed warning caused by slight difference in input function type
    by John Riehl.
    - Fix compiler warnings: ServerShutdownTest, DelayedJoinGroup function
    signature by Blake Smith.
    - Fix Scala 2.11 warnings. `Pair` has been deprecated, `try` without
    `catch` and `finally` is useless and initialisation order fix by Ismael
    Juma.

----


> Eliminate Compilation Warnings for 0.8 Final Release
> ----------------------------------------------------
>
>                 Key: KAFKA-1054
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1054
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Guozhang Wang
>              Labels: newbie
>             Fix For: 0.9.0
>
>         Attachments: KAFKA-1054-20150426-V1.patch, 
> KAFKA-1054-20150426-V2.patch, KAFKA-1054.patch, KAFKA-1054_Mar_10_2015.patch
>
>
> Currently we have a total number of 38 warnings for source code compilation 
> of 0.8.
> 1) 3 from "Unchecked type pattern"
> 2) 6 from "Unchecked conversion"
> 3) 29 from "Deprecated Hadoop API functions"
> It's better we finish these before the final release of 0.8



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to