[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516577#comment-14516577
]
Gwen Shapira commented on KAFKA-1928:
-------------------------------------
Moved SocketServer to use Selector.
All tests are passing at this point, but its still kinda messy.
[~harsha_ch] - you can take a look and see how much it changes things for the
security patches.
This is far from final, but should give you a good idea of what changed.
Known issues:
* None of Jun's comments in RB are addressed
* I may have messed up metrics completely. I'm not sure what I'm doing there
and not sure how we test those.
* Known messed metric: We can't measure SentBytes for generic Send (which is
why the old metrics just counted number of messages). There's a big TODO in
Selector for this.
* Request.requestKey should be renamed and changed to String
* I removed testNullResponse from SocketServerTest. Now that selectionKeys are
encapsulated by Selectors that are encapsulated by Processors that are
encapsulated by SocketServer - I'm not sure there's a good way to write this
test as part of SocketServerTest.
> Move kafka.network over to using the network classes in
> org.apache.kafka.common.network
> ---------------------------------------------------------------------------------------
>
> Key: KAFKA-1928
> URL: https://issues.apache.org/jira/browse/KAFKA-1928
> Project: Kafka
> Issue Type: Sub-task
> Components: security
> Reporter: Jay Kreps
> Assignee: Gwen Shapira
> Attachments: KAFKA-1928.patch, KAFKA-1928_2015-04-28_00:09:40.patch
>
>
> As part of the common package we introduced a bunch of network related code
> and abstractions.
> We should look into replacing a lot of what is in kafka.network with this
> code. Duplicate classes include things like Receive, Send, etc. It is likely
> possible to also refactor the SocketServer to make use of Selector which
> should significantly simplify it's code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
