> On April 29, 2015, 11:46 p.m., Gwen Shapira wrote: > > Overall, looks good. > > I had a bunch of nits :)
Thanks for the review Gwen! > On April 29, 2015, 11:46 p.m., Gwen Shapira wrote: > > build.gradle, line 402 > > <https://reviews.apache.org/r/33614/diff/4/?file=944422#file944422line402> > > > > What's this? This is required for junit tests. > On April 29, 2015, 11:46 p.m., Gwen Shapira wrote: > > log4j/src/main/java/org/apache/kafka/log4j/KafkaLog4jAppender.java, lines > > 130-131 > > <https://reviews.apache.org/r/33614/diff/4/?file=944426#file944426line130> > > > > Any idea why we are using ByteArraySerializer (and not > > StringSerializer) when the messages are strings? > > > > I know the original class was the same, but I'm not sure why. Honestly, I had the same question. However, I did not want to change the original behaviour. I doubt using StringSerializer will change the behaviour, but having byte serializer is helpful for testing as it can be easily overrided by MockProducer. If we really have to use StringSerializer, I can create a wrapper on top of current MockProducer to support String values. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review82056 ----------------------------------------------------------- On April 30, 2015, 7:22 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33614/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 7:22 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2132 > https://issues.apache.org/jira/browse/KAFKA-2132 > > > Repository: kafka > > > Description > ------- > > KAFKA-2132: Move Log4J appender to clients module > > > Diffs > ----- > > build.gradle fef515b3b2276b1f861e7cc2e33e74c3ce5e405b > checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 5d36a019e3dbfb93737a9cd23404dcd1c5d836d1 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 41366a14590d318fced0e83d6921d8035fa882da > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java > PRE-CREATION > settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 > > Diff: https://reviews.apache.org/r/33614/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
