[ 
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522757#comment-14522757
 ] 

Dong Lin commented on KAFKA-2084:
---------------------------------

Here is my 2 cents. I vote for your 2nd approach: ClientQuotaMetrics2 which 
maintains per-client metrics for a single entity. My argument is that the 
clientQuotaMetrics class doesn't need to distinguish between producer quota or 
consumer quota. This semantics difference is better maintained by the one who 
creates clientQuotaMetrics instance.

> byte rate metrics per client ID (producer and consumer)
> -------------------------------------------------------
>
>                 Key: KAFKA-2084
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2084
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Aditya Auradkar
>            Assignee: Aditya Auradkar
>         Attachments: KAFKA-2084.patch, KAFKA-2084_2015-04-09_18:10:56.patch, 
> KAFKA-2084_2015-04-10_17:24:34.patch, KAFKA-2084_2015-04-21_12:21:18.patch, 
> KAFKA-2084_2015-04-21_12:28:05.patch
>
>
> We need to be able to track the bytes-in/bytes-out rate on a per-client ID 
> basis. This is necessary for quotas.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to