[ 
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539267#comment-14539267
 ] 

ASF GitHub Bot commented on KAFKA-2167:
---------------------------------------

GitHub user neeleshCloud opened a pull request:

    https://github.com/apache/kafka/pull/63

    Corrected the Changes in ZkUtils.scala - KAFKA-2167

    Corrected Spelling errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neeleshCloud/kafka 0.8.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/63.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #63
    
----
commit 904af08e2437d2ddf57017a3f3f1decc2087c491
Author: Neelesh Srinivas Salian <nsal...@cloudera.com>
Date:   2015-05-12T05:17:42Z

    KAFKA-2167

----


> ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
> --------------------------------------------------------------
>
>                 Key: KAFKA-2167
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2167
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jon Bringhurst
>            Assignee: Neelesh Srinivas Salian
>              Labels: newbie
>
> I'm not 100% sure on this, but it seems like "persistent" should instead say 
> "ephemeral" in the JavaDoc. Also, note that "parrent" is misspelled.
> {noformat}
>   /**
>    * Update the value of a persistent node with the given path and data.
>    * create parrent directory if necessary. Never throw NodeExistException.
>    */
>   def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit 
> = {
>     try {
>       client.writeData(path, data)
>     }
>     catch {
>       case e: ZkNoNodeException => {
>         createParentPath(client, path)
>         client.createEphemeral(path, data)
>       }
>       case e2 => throw e2
>     }
>   }
> {noformat}
> should be:
> {noformat}
>   /**
>    * Update the value of an ephemeral node with the given path and data.
>    * create parent directory if necessary. Never throw NodeExistException.
>    */
>   def updateEphemeralPath(client: ZkClient, path: String, data: String): Unit 
> = {
>     try {
>       client.writeData(path, data)
>     }
>     catch {
>       case e: ZkNoNodeException => {
>         createParentPath(client, path)
>         client.createEphemeral(path, data)
>       }
>       case e2 => throw e2
>     }
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to