-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/
-----------------------------------------------------------
(Updated June 3, 2015, 11:36 p.m.)
Review request for kafka.
Bugs: KAFKA-2210
https://issues.apache.org/jira/browse/KAFKA-2210
Repository: kafka
Description
-------
Addressing review comments from Jun.
Diffs (updated)
-----
core/src/main/scala/kafka/api/OffsetRequest.scala
3d483bc7518ad76f9548772522751afb4d046b78
core/src/main/scala/kafka/common/AuthorizationException.scala PRE-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala
c75c68589681b2c9d6eba2b440ce5e58cddf6370
core/src/main/scala/kafka/security/auth/Acl.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/Authorizer.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/KafkaPrincipal.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/Operation.java PRE-CREATION
core/src/main/scala/kafka/security/auth/PermissionType.java PRE-CREATION
core/src/main/scala/kafka/security/auth/Resource.scala PRE-CREATION
core/src/main/scala/kafka/security/auth/ResourceType.java PRE-CREATION
core/src/main/scala/kafka/server/KafkaApis.scala
387e387998fc3a6c9cb585dab02b5f77b0381fbf
core/src/main/scala/kafka/server/KafkaConfig.scala
6f25afd0e5df98258640252661dee271b1795111
core/src/main/scala/kafka/server/KafkaServer.scala
e66710d2368334ece66f70d55f57b3f888262620
core/src/test/resources/acl.json PRE-CREATION
core/src/test/scala/unit/kafka/security/auth/AclTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/security/auth/KafkaPrincipalTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/security/auth/ResourceTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala
71f48c07723e334e6489efab500a43fa93a52d0c
Diff: https://reviews.apache.org/r/34492/diff/
Testing
-------
Thanks,
Parth Brahmbhatt