----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35261/#review87661 -----------------------------------------------------------
Thanks for the patch. A few comments below. clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java <https://reviews.apache.org/r/35261/#comment140068> MockProducer and MockConsumer are meant for testing a Kafka application. So, it's convenient to include them in the client package instead of the test package. clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java <https://reviews.apache.org/r/35261/#comment140069> The comment is inaccurate. We are passing in an empty cluster, not a null. This is an existing problem, but could you fix it in this jira too? clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java <https://reviews.apache.org/r/35261/#comment140070> Could we add another constructor to pass in the partitioner? clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java <https://reviews.apache.org/r/35261/#comment140071> We should pass in the key/value object, instead of null to the partitioner. - Jun Rao On June 9, 2015, 7 p.m., Alexander Pakulov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35261/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 7 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2232 > https://issues.apache.org/jira/browse/KAFKA-2232 > > > Repository: kafka > > > Description > ------- > > KAFKA-2232: Make MockProducer generic > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java > f50da825756938c193d7f07bee953e000e2627d9 > clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java > e66491cc82f11641df6516e7d7abb4a808c27368 > > clients/src/test/java/org/apache/kafka/clients/consumer/MockConsumerTest.java > 677edd385f35d4262342b567262c0b874876d25b > > clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java > 6372f1a7f7f77d96ba7be05eb927c004f7fefb73 > clients/src/test/java/org/apache/kafka/test/MockSerializer.java > e75d2e4e58ae0cdbe276d3a3b652e47795984791 > > Diff: https://reviews.apache.org/r/35261/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pakulov > >
