> On June 12, 2015, 1:18 a.m., Jun Rao wrote: > > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java, > > lines 256-257 > > <https://reviews.apache.org/r/35371/diff/1/?file=983518#file983518line256> > > > > Waiting a second on this could be long and is not always reliable. > > Perhaps, we can introduce a waitUntil util like in kafka.utils.TestUtils > > and use it here.
I noticed that SelectorTest already provided a blockingConnect function, so I updated the test to use that. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35371/#review87667 ----------------------------------------------------------- On June 12, 2015, 4:19 p.m., Jason Gustafson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35371/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 4:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2266 > https://issues.apache.org/jira/browse/KAFKA-2266 > > > Repository: kafka > > > Description > ------- > > KAFKA-2266; use blockingConnect function in idle disconnect test case > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/network/Selector.java > effb1e63081ed2c1fff6d08d4ecdf8a3cb43e40a > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > d23b4b6a7060eeefa9f47f292fd818c881d789c1 > > Diff: https://reviews.apache.org/r/35371/diff/ > > > Testing > ------- > > > Thanks, > > Jason Gustafson > >
