----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35454/#review88106 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaConfig.scala (line 242) <https://reviews.apache.org/r/35454/#comment140509> I would prefer keeping the config as offsets.retention.minutes (since this is a bit different from log retention minutes). i.e., we should update the website doc instead. - Joel Koshy On June 15, 2015, 11:22 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35454/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 11:22 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2159 > https://issues.apache.org/jira/browse/KAFKA-2159 > > > Repository: kafka > > > Description > ------- > > Renamed offsets.retention.minutes to offsets.topic.retention.minutes, > offsetsTopicSegmentBytes parameter passed in KafkaServer.createOffsetManager() > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaConfig.scala > 2d75186a110075e0c322db4b9f7a8c964a7a3e88 > core/src/main/scala/kafka/server/KafkaServer.scala > b320ce9f6a12c0ee392e91beb82e8804d167f9f4 > > Diff: https://reviews.apache.org/r/35454/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
