Thanks. +1 (non-binding) ________________________________________ From: Ashish Singh [asi...@cloudera.com] Sent: Tuesday, June 23, 2015 12:04 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Aditya, Yes. Updated the KIP with notes on the parameter. Will update the patch. On Tue, Jun 23, 2015 at 11:51 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey Ashish, > > Last hangout, I think we discussed adding a "num-iterations" parameter to > the script. Do you plan to support that? > > Aditya > > ________________________________________ > From: Neha Narkhede [n...@confluent.io] > Sent: Tuesday, June 23, 2015 11:24 AM > To: dev@kafka.apache.org > Cc: Jun Rao > Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to > ConsumerGroupCommand > > +1 > > On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <asi...@cloudera.com> > wrote: > > > Hey Guys, > > > > We had some discussion over mail and in KIP hangout. I will update the RB > > with proposed changes. > > > > > > On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <asi...@cloudera.com> > > wrote: > > > > > Hi Neha, > > > > > > Answers inline. > > > > > > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <n...@confluent.io> > > wrote: > > > > > >> Thanks for submitting the KIP, Ashish! Few questions. > > >> > > >> 1. Can you specify more details around how you expect csv output to be > > >> used. Same for json. > > >> > > > CSV takes less storage space and is more convenient for shell > operations. > > > A simple diff between two csv outputs would tell you if something > changed > > > or not. It's also common in certain industries when dealing with legacy > > > systems and workflows. Try importing JSON into MS Excel. > > > > > > JSON on the other hand has easy interpretation, compact notation and > > > supports Hierarchical Data. If someone is planning to run the tool > > > periodically and send the output to some server or even just persist it > > > somewhere, JSON is probably the way to go. > > > > > > 2. If we add these options, would you still need the old format. If > > >> csv/json offers more convenience, should we have a plan to phase out > the > > >> old format? > > >> > > > Probably not, but having it around will not hurt. Having three output > > > formats is not that bad and I do not expect this list to grow in > future. > > > > > >> > > >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <asi...@cloudera.com> > > >> wrote: > > >> > > >> > Jun, > > >> > > > >> > Can we add this as part of next KIP's agenda? > > >> > > > >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira < > gshap...@cloudera.com> > > >> > wrote: > > >> > > > >> > > Maybe bring it up at the next KIP call, to make sure everyone is > > >> aware? > > >> > > > > >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh < > asi...@cloudera.com> > > >> > wrote: > > >> > > > Hi Guys, > > >> > > > > > >> > > > This has been lying around for quite some time. Should I start a > > >> voting > > >> > > > thread on this? > > >> > > > > > >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh < > > asi...@cloudera.com> > > >> > > wrote: > > >> > > > > > >> > > >> Had to change the title of the page and that surprisingly > changed > > >> the > > >> > > link > > >> > > >> as well. KIP-23 is now available at here > > >> > > >> < > > >> > > > > >> > > > >> > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556 > > >> > > > >> > > >> . > > >> > > >> > > >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh < > > asi...@cloudera.com > > >> > > > >> > > wrote: > > >> > > >> > > >> > > >>> Hi Guys, > > >> > > >>> > > >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping > > >> options > > >> > to > > >> > > >>> ConsumerGroupCommand > > >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, > for > > >> > > KAFKA-313 > > >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The > changes > > >> made > > >> > as > > >> > > >>> part of the JIRA can be found here < > > >> > > https://reviews.apache.org/r/28096/>. > > >> > > >>> > > >> > > >>> Comments and suggestions are welcome! > > >> > > >>> > > >> > > >>> -- > > >> > > >>> > > >> > > >>> Regards, > > >> > > >>> Ashish > > >> > > >>> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> -- > > >> > > >> > > >> > > >> Regards, > > >> > > >> Ashish > > >> > > >> > > >> > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > > > >> > > > Regards, > > >> > > > Ashish > > >> > > > > >> > > > >> > > > >> > > > >> > -- > > >> > > > >> > Regards, > > >> > Ashish > > >> > > > >> > > >> > > >> > > >> -- > > >> Thanks, > > >> Neha > > >> > > > > > > > > > > > > -- > > > > > > Regards, > > > Ashish > > > > > > > > > > > -- > > > > Regards, > > Ashish > > > > > > -- > Thanks, > Neha > -- Regards, Ashish
