> On July 2, 2015, 8:01 a.m., Ewen Cheslack-Postava wrote: > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala, line 110 > > <https://reviews.apache.org/r/35850/diff/2/?file=997797#file997797line110> > > > > Since this is a warning, can we just use warn() instead of info()? > > Otherwise, this trivial patch LGTM!
The reason I had it as info was if someone is suppressing warnings they might not get this message. However, I guess that is the price they pay for suppressing warnings. Made the change. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/#review90199 ----------------------------------------------------------- On July 2, 2015, 4:04 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35850/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 4:04 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2301 > https://issues.apache.org/jira/browse/KAFKA-2301 > > > Repository: kafka > > > Description > ------- > > KAFKA-2301: Deprecate ConsumerOffsetChecker > > > Diffs > ----- > > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala > 3d52f62c88a509a655cf1df6232b738c25fa9b69 > > Diff: https://reviews.apache.org/r/35850/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
