[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621144#comment-14621144
]
Guozhang Wang commented on KAFKA-1740:
--------------------------------------
Thanks for the findings [~onurkaraman]! And sorry I overlooked this issue when
making the commit.
As for the solution options, I actually still prefer option 1 because I feel it
makes more sense to me to only log generation id increase when we finished form
a new group so that we can log the new group members along with the new
generation id (so I guess it is purely personal taste :)
Anyways I think this is an urgent bug fix, so if you are OK with option 1 I can
extract it from [~hachikuji]'s patch and commit it to unblock people?
> Merge Offset manager into Coordinator
> -------------------------------------
>
> Key: KAFKA-1740
> URL: https://issues.apache.org/jira/browse/KAFKA-1740
> Project: Kafka
> Issue Type: Sub-task
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Priority: Critical
> Fix For: 0.8.3
>
> Attachments: KAFKA-1740.patch, KAFKA-1740_2015-06-29_18:21:42.patch,
> KAFKA-1740_2015-06-29_18:44:54.patch
>
>
> This JIRA involves refactoring offset manager and merge it into coordinator,
> including adding the logic for consumer-id / generation-id checking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
