-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/
-----------------------------------------------------------
(Updated July 14, 2015, 5:34 p.m.)
Review request for kafka, Joel Koshy and Jun Rao.
Bugs: KAFKA-2205
https://issues.apache.org/jira/browse/KAFKA-2205
Repository: kafka
Description (updated)
-------
KAFKA-2186; Follow-up to KAFKA-1650 - add selective offset commit to consumer
connector API; reviewed by Joel Koshy
Revert "KAFKA-2186; Follow-up to KAFKA-1650 - add selective offset commit to"
This reverts commit 23ff851f30bb55e794aefd2fae5367845d9230ee.
KAFKA-1737; Enforce ZKSerializer while creating ZkClient; reviewed by Guozhang
Wang
kafka-2189; Snappy compression of message batches less efficient in 0.8.2.1;
patched by Ismael Juma; reviewed by Jun Rao
KAFKA-2186; Follow-up to KAFKA-1650 - add selective offset commit to consumer
connector API; reviewed by Joel Koshy
KAFKA-2091; Expose a partitioner interface in the new producer
(https://cwiki.apache.org/confluence/display/KAFKA/KIP-+22+-+Expose+a+Partitioner+interface+in+the+new+producer);
reviewed by Joel Koshy and Jay Kreps
kafka-2185; Update to Gradle 2.4; patched by Ismael Juma; reviewed by Jun Rao
KAFKA-2199 Make signing artifacts optional and disabled by default for
SNAPSHOTs and allow remote Maven repository configuration from the command
line.
kafka-2226; NullPointerException in TestPurgatoryPerformance; patched by
Yasuhiro Matsuda; reviewed by Onur Karaman, Guozhang Wang and Jun Rao
KAFKA-2161; Fix a few copyrights
KAFKA-2208; add consumer side error handling upon coordinator failure; reviewed
by Onur Karaman
kafka-1928; Move kafka.network over to using the network classes in
org.apache.kafka.common.network; patched by Gwen Shapira; reviewed by Joel
Koshy, Jay Kreps, Jiangjie Qin, Guozhang Wang and Jun Rao
KAFKA-2246; UnknownTopicOrPartitionException should be an instance of
InvalidMetadataException; reviewed by Ewen Cheslack-Postava and Joel Koshy
KAFKA-2253; fix deadlock between removeWatchersLock and watcher operations list
lock; reviewed by Onur Karaman and Jiangjie Qin
kafka-2005; Generate html report for system tests; patched by Ashish Singh;
reviewed by Jun Rao
kafka-2266; Client Selector can drop idle connections without notifying
NetworkClient; patched by Jason Gustafson; reviewed by Jun Rao
kafka-2232; make MockProducer generic; patched by Alexander Pakulov; reviewed
by Jun Rao
kafka-2164; ReplicaFetcherThread: suspicious log message on reset offset;
patched by Alexey Ozeritski; reviewed by Jun Rao
kafka-2101; Metric metadata-age is reset on a failed update; patched by Tim
Brooks; reviewed by Jun Rao
kafka-2195; Add versionId to AbstractRequest.getErrorResponse and
AbstractRequest.getRequest; patched by Andrii Biletskyi; reviewed by Jun Rao
kafka-2270; incorrect package name in unit tests; patched by Proneet Verma;
reviewed by Jun Rao
kafka-2272; listeners endpoint parsing fails if the hostname has capital
letter; patched by Sriharsha Chintalapani; reviewed by Jun Rao
kafka-2264; SESSION_TIMEOUT_MS_CONFIG in ConsumerConfig should be int; patched
by Manikumar Reddy; reviewed by Jun Rao
kafka-2252; Socket connection closing is logged, but not corresponding opening
of socket; patched by Gwen Shapira; reviewed by Jun Rao
kafka-2262; LogSegmentSize validation should be consistent; patched by
Manikumar Reddy; reviewed by Jun Rao
trivial fix for stylecheck error on Jenkins
kafka-2249; KafkaConfig does not preserve original Properties; patched by Gwen
Shapira; reviewed by Jun Rao
kafka-2265; creating a topic with large number of partitions takes a long time;
patched by Manikumar Reddy; reviewed by Jun Rao
kafka-2234; Partition reassignment of a nonexistent topic prevents future
reassignments; patched by Manikumar Reddy; reviewed by Jun Rao
trivial change to fix unit test failure introduced in kafka-2234
kafka-1758; corrupt recovery file prevents startup; patched by Manikumar Reddy;
reviewed by Neha Narkhede and Jun Rao
kafka-1646; Improve consumer read performance for Windows; patched by Honghai
Chen; reviewed by Jay Kreps and Jun Rao
kafka-2012; Broker should automatically handle corrupt index files; patched by
Manikumar Reddy; reviewed by Jun Rao
kafka-2290; OffsetIndex should open RandomAccessFile consistently; patched by
Chris Black; reviewed by Jun Rao
kafka-2235; LogCleaner offset map overflow; patched by Ivan Simoneko; reviewed
by Jun Rao
KAFKA-2245; Add response tests for consumer coordinator; reviewed by Joel Koshy
KAFKA-2293; Fix incorrect format specification in Partition.scala; reviewed by
Joel Koshy
kafka-2168; New consumer poll() can block other calls like position(),
commit(), and close() indefinitely; patched by Jason Gustafson; reviewed by Jay
Kreps, Ewen Cheslack-Postava, Guozhang Wang and Jun Rao
KAFKA-2294; javadoc compile error due to illegal <p/> , build failing (jdk 8);
patched by Jeff Maxwell; reviewed by Jakob Homan
KAFKA-2281: avoid unnecessary value copying if logAsString is false; reviewed
by Guozhang Wang
KAFKA-2168: minor follow-up patch; reviewed by Guozhang Wang
KAFKA-1740: merge offset manager into consumer coordinator; reviewed by Onur
Karaman and Jason Gustafson
kafka-2248; Use Apache Rat to enforce copyright headers; patched by Ewen
Cheslack-Postava; reviewed by Gwen Shapira, Joel Joshy and Jun Rao
kafka-2132; Move Log4J appender to a separate module; patched by Ashish Singh;
reviewed by Gwen Shapira, Aditya Auradkar and Jun Rao
KAFKA-2314: proper MirrorMaker's message handler help message; reviewed by
Guozhang Wang
kafka-1367; Broker topic metadata not kept in sync with ZooKeeper; patched by
Ashish Singh; reviewed by Jun Rao
KAFKA-2304 Supported enabling JMX in Kafka Vagrantfile patch by Stevo Slavic
reviewed by Ewen Cheslack-Postava
KAFKA-2306: add another metric for buffer exhausted; reviewed by Guozhang Wang
KAFKA-2317: follow-up of KAFKA1367; reviewed by Guozhang Wang
KAFKA-2313: javadoc fix for KafkaConsumer deserialization; reviewed by Guozhang
Wang
KAFKA-2205: First commit
Some fixes
KAFKA-2205
KAFKA-2205
Addressing Jun's comments
Addressing Jun's comments
Addressing Jun's comments
Addressing Jun's comments
Diffs (updated)
-----
.rat-excludes 01d629817c8a4b2db3c11d8e6a7fa13a7e4856c2
README.md 946ec62cc71df93c905c5f35caf5cdb9c78e5c10
Vagrantfile 55c67ddda458199c0b5168c8f0c367d368a6f402
build.gradle cd2aa838fd53e8124f308979b1d70efe0c5725a6
checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
da76cc257b4cfe3c4bce7120a1f14c7f31ef8587
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
cf32e4e7c40738fe6d8adc36ae0cfad459ac5b0b
clients/src/main/java/org/apache/kafka/clients/InFlightRequests.java
936487b16e7ac566f8bdcd39a7240ceb619fd30e
clients/src/main/java/org/apache/kafka/clients/KafkaClient.java
1311f85847b022efec8cb05c450bb18231db6979
clients/src/main/java/org/apache/kafka/clients/Metadata.java
07f1cdb1fe920b0c7a5f2d101ddc40c689e1b247
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
435fbb5116e80302eba11ed1d3069cb577dbdcbd
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java
8f587bc0705b65b3ef37c86e0c25bb43ab8803de
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
bdff518b732105823058e6182f445248b45dc388
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java
1ca75f83d3667f7d01da1ae2fd9488fb79562364
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerWakeupException.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
d301be4709f7b112e1f3a39f3c04cfa65f00fa60
clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java
f50da825756938c193d7f07bee953e000e2627d9
clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java
b2764df11afa7a99fce46d1ff48960d889032d14
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
ef9dd5238fbc771496029866ece1d85db6d7b7a5
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Heartbeat.java
e7cfaaad296fa6e325026a5eee1aaf9b9c0fe1fe
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestFuture.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
cee75410127dd1b86c1156563003216d93a086b3
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
8e336a3aa96c73f52beaeb56b931baf4b026cf21
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
3c34610dbc8a68e4561e7264e0b545de3d93cef2
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
187d0004c8c46b6664ddaffecc6166d4b47351e5
clients/src/main/java/org/apache/kafka/clients/producer/internals/ErrorLoggingCallback.java
678d1c6accd2a119b54dbb4740604d25fa8f9de4
clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java
93e799105fb6cc5c49a129c0db099a3a973b2ab3
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
87dbd64f30f35dbf31d3820f9819a63c6c0d1e58
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
1e943d621732889a1c005b243920dc32cea7af66
clients/src/main/java/org/apache/kafka/common/Node.java
f4e4186c7602787e58e304a2f1c293a633114656
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
c4fa058692f50abb4f47bd344119d805c60123f5
clients/src/main/java/org/apache/kafka/common/errors/UnknownTopicOrPartitionException.java
ec423bd01298c6c90d9a65d87ccd6ffcb8ec88d4
clients/src/main/java/org/apache/kafka/common/network/ByteBufferReceive.java
129ae827bccbd982ad93d56e46c6f5c46f147fe0
clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java
c8213e156ec9c9af49ee09f5238492318516aaa3
clients/src/main/java/org/apache/kafka/common/network/MultiSend.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java
fc0d168324aaebb97065b0aafbd547a1994d76a7
clients/src/main/java/org/apache/kafka/common/network/NetworkSend.java
68327cd3a734fd429966d3e2016a2488dbbb19e5
clients/src/main/java/org/apache/kafka/common/network/Receive.java
4e33078c1eec834bd74aabcb5fc69f18c9d6d52a
clients/src/main/java/org/apache/kafka/common/network/Selectable.java
b5f8d83e89f9026dc0853e5f92c00b2d7f043e22
clients/src/main/java/org/apache/kafka/common/network/Selector.java
57de0585e5e9a53eb9dcd99cac1ab3eb2086a302
clients/src/main/java/org/apache/kafka/common/network/Send.java
5d321a09e470166a1c33639cf0cab26a3bce98ec
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
5b898c8f8ad5d0469f469b600c4b2eb13d1fc662
clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
5e5308ec0e333179a9abbf4f3b750ea25ab57967
clients/src/main/java/org/apache/kafka/common/requests/ConsumerMetadataRequest.java
04b90bfe62456a6739fe0299f1564dbd1850fe58
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
8686d83aa52e435c6adafbe9ff4bd1602281072a
clients/src/main/java/org/apache/kafka/common/requests/HeartbeatRequest.java
51d081fa296fd7c170a90a634d432067afcfe772
clients/src/main/java/org/apache/kafka/common/requests/HeartbeatResponse.java
f548cd0ef70929b35ac887f8fccb7b24c3e2c11a
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java
6795682258e6b329cc3caa245b950b4dbcf0cf45
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java
fd9c545c99058ad3fbe3b2c55ea8b6ea002f5a51
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetRequest.java
19267ee8aad5a2f5a84cecd6fc563f00329d5035
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
7e0ce159a2ddd041fc06116038bd5831bbca278b
clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java
44e2ce61899889601b6aee71fa7f7ddb4a65a255
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java
8bf6cbb79a92b0878096e099ec9169d21e6d7023
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java
70844d65369f6ff300cbeb513dbb6650050c7eec
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
deec1fa480d5a5c5884a1c007b076aa64e902472
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchResponse.java
512a0ef7e619d54e74122c38119209f5cf9590e3
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java
fabeae3083a8ea55cdacbb9568f3847ccd85bab4
clients/src/main/java/org/apache/kafka/common/requests/RequestSend.java
27cbf390c7f148ffa8c5abc154c72cbf0829715c
clients/src/main/java/org/apache/kafka/common/requests/ResponseSend.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/utils/Utils.java
f73eedb030987f018d8446bb1dcd98d19fa97331
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java
928087d29deb80655ca83726c1ebc45d76468c1f
clients/src/test/java/org/apache/kafka/clients/MockClient.java
5e3fab13e3c02eb351558ec973b949b3d1196085
clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
8b278892883e63899b53e15efb9d8c926131e858
clients/src/test/java/org/apache/kafka/clients/consumer/MockConsumerTest.java
677edd385f35d4262342b567262c0b874876d25b
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java
b06c4a73e2b4e9472cd772c8bc32bf4a29f431bb
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java
419541011d652becf0cda7a5e62ce813cddb1732
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatTest.java
ecc78cedf59a994fcf084fa7a458fe9ed5386b00
clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java
e000cf8e10ebfacd6c9ee68d7b88ff8c157f73c6
clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java
6372f1a7f7f77d96ba7be05eb927c004f7fefb73
clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java
5dadd0e3554577ad6be28a18ff5ab08f8b31050f
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
d5b306b026e788b4e5479f3419805aa49ae889f3
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
e3cc1967e407b64cc734548c19e30de700b64ba8
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
2ebe3c21f611dc133a2dbb8c7dfb0845f8c21498
clients/src/test/java/org/apache/kafka/test/MockSelector.java
ea89b06a4c9e5bb351201299cd3037f5226f0e6c
clients/src/test/java/org/apache/kafka/test/MockSerializer.java
e75d2e4e58ae0cdbe276d3a3b652e47795984791
core/src/main/scala/kafka/Kafka.scala
9efabaadd7d22001a75c3720e2d691f45cd83d9e
core/src/main/scala/kafka/admin/AdminUtils.scala
f06edf41c732a7b794e496d0048b0ce6f897e72b
core/src/main/scala/kafka/admin/ConfigCommand.scala PRE-CREATION
core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
1c3b3802ac221d570e7610458e50518b4499e7ed
core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala
3b3cd67d890e05c00d2a36a577f940347a0d387a
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
acaa6112db979dc775af6385c58d2e52786dfba9
core/src/main/scala/kafka/admin/TopicCommand.scala
8e6f18633b25bf1beee3f813b28ef7aa7d779d7b
core/src/main/scala/kafka/api/ConsumerMetadataRequest.scala
a3b1b78adb760eaeb029466b54f335a29caf3b0f
core/src/main/scala/kafka/api/ControlledShutdownRequest.scala
fe81635c864cec03ca1d4681c9c47c3fc4f975ee
core/src/main/scala/kafka/api/FetchRequest.scala
b038c15186c0cbcc65b59479324052498361b717
core/src/main/scala/kafka/api/FetchResponse.scala
75aaf57fb76ec01660d93701a57ae953d877d81c
core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala
431190ab94afc4acfc14348a1fc720e17c071cea
core/src/main/scala/kafka/api/OffsetCommitRequest.scala
317daed18db8b02635927d81fbcad623f137de5e
core/src/main/scala/kafka/api/OffsetFetchRequest.scala
fa8bd6a145fd3f08a5f78fcfa813ed7417ccffd2
core/src/main/scala/kafka/api/OffsetRequest.scala
3d483bc7518ad76f9548772522751afb4d046b78
core/src/main/scala/kafka/api/ProducerRequest.scala
570b2da1d865086f9830aa919a49063abbbe574d
core/src/main/scala/kafka/api/RequestKeys.scala
ef7a86ec3324028496d6bb7c7c6fec7d7d19d64e
core/src/main/scala/kafka/api/StopReplicaRequest.scala
5e14987c990fe561c01dac2909f5ed21a506e038
core/src/main/scala/kafka/api/TopicMetadataRequest.scala
363bae01752318f3849242b97a6619747697c1d9
core/src/main/scala/kafka/api/UpdateMetadataRequest.scala
69f0397b187a737b4ddf50e390d3c2f418ce6b5d
core/src/main/scala/kafka/client/ClientUtils.scala
62394c0d3813f19a443cf862c8bc6c5808be9f88
core/src/main/scala/kafka/cluster/EndPoint.scala
e9008e6d758be04bebe3cc70952c13dc55dc58fb
core/src/main/scala/kafka/cluster/Partition.scala
730a232482fdf77be5704cdf5941cfab3828db88
core/src/main/scala/kafka/common/OffsetMetadataAndError.scala
6b4242c7cd1df9b3465db0fec35a25102c76cd60
core/src/main/scala/kafka/common/Topic.scala
ad759786d1c22f67c47808c0b8f227eb2b1a9aa8
core/src/main/scala/kafka/common/TopicAndPartition.scala
df3db912f5daef6a25b4b2dd2220d2cc3795bce6
core/src/main/scala/kafka/consumer/SimpleConsumer.scala
31a2639477bf66f9a05d2b9b07794572d7ec393b
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
0b0dca15c1ccf7579559f91902602cca78d1b252
core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala
f2fa36feb3722fa9565fb20c93f50aaf4c05e106
core/src/main/scala/kafka/controller/ControllerChannelManager.scala
6cf13f0a1f7f31ff9367197a435e0ae4427b6438
core/src/main/scala/kafka/controller/KafkaController.scala
69bba243a9a511cc5292b43da0cc48e421a428b0
core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala
3b15ab4eef22c6f50a7483e99a6af40fb55aca9f
core/src/main/scala/kafka/controller/PartitionStateMachine.scala
92fd92d135b24931de970347eae49ad24dd1f5c4
core/src/main/scala/kafka/controller/TopicDeletionManager.scala
64ecb499f24bc801d48f86e1612d927cc08e006d
core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala
af06ad45cdc46ac3bc27898ebc1a5bd5b1c7b19e
core/src/main/scala/kafka/coordinator/ConsumerGroupMetadata.scala
47bdfa7cc86fd4e841e2b1d6bfd40f1508e643bd
core/src/main/scala/kafka/coordinator/CoordinatorMetadata.scala
c39e6de34ee531c6dfa9107b830752bd7f8fbe59
core/src/main/scala/kafka/javaapi/TopicMetadataRequest.scala
b0b7be14d494ae8c87f4443b52db69d273c20316
core/src/main/scala/kafka/javaapi/consumer/ConsumerConnector.java
cc3400ff81fc0db69b5129ad7b440f20a211a79d
core/src/main/scala/kafka/log/FileMessageSet.scala
2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala
84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogCleaner.scala
c9ade7208798fbd92d4ff49e183fe5f8925c82a9
core/src/main/scala/kafka/log/LogConfig.scala
a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogManager.scala
e781ebac2677ebb22e0c1fef0cf7e5ad57c74ea4
core/src/main/scala/kafka/log/LogSegment.scala
ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/log/OffsetIndex.scala
a1082aefd60ed4207f90feec29e700471d175ef8
core/src/main/scala/kafka/network/BlockingChannel.scala
6e2a38eee8e568f9032f95c75fa5899e9715b433
core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala
c0d77261353478232ab85591c182be57845b3f13
core/src/main/scala/kafka/network/BoundedByteBufferSend.scala
b95b73b71252932867c60192b3d5b91efe99e122
core/src/main/scala/kafka/network/ByteBufferSend.scala
af30042a4c713418ecd83b6c6c17dfcbdc101c62
core/src/main/scala/kafka/network/Handler.scala
a0300336b8cb5a2d5be68b7b48bdbe045bf99324
core/src/main/scala/kafka/network/RequestChannel.scala
1d0024c8f0c2ab0efa6d8cfca6455877a6ed8026
core/src/main/scala/kafka/network/RequestOrResponseSend.scala PRE-CREATION
core/src/main/scala/kafka/network/SocketServer.scala
edf6214278935c031cf493d72d266e715d43dd06
core/src/main/scala/kafka/network/Transmission.scala
2827103d7e57789bb04859bdeb9d4720c8bd060c
core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala
5d36a019e3dbfb93737a9cd23404dcd1c5d836d1
core/src/main/scala/kafka/producer/SyncProducer.scala
0f09951329a8a8f86bd4d1512e8d10eb151ddb43
core/src/main/scala/kafka/server/ConfigHandler.scala PRE-CREATION
core/src/main/scala/kafka/server/DelayedOperation.scala
123078d97a7bfe2121655c00f3b2c6af21c53015
core/src/main/scala/kafka/server/KafkaApis.scala
387e387998fc3a6c9cb585dab02b5f77b0381fbf
core/src/main/scala/kafka/server/KafkaConfig.scala
9efa15ca5567b295ab412ee9eea7c03eb4cdc18b
core/src/main/scala/kafka/server/KafkaServer.scala
ea6d165d8e5c3146d2c65e8ad1a513308334bf6f
core/src/main/scala/kafka/server/MessageSetSend.scala
566764850cc60b9d35a4b51abd89a8109f340f5d
core/src/main/scala/kafka/server/OffsetManager.scala
5cca85cf727975f6d3acb2223fd186753ad761dc
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala
b31b432a226ba79546dd22ef1d2acbb439c2e9a3
core/src/main/scala/kafka/server/ReplicaManager.scala
59c9bc3ac3a8afc07a6f8c88c5871304db588d17
core/src/main/scala/kafka/server/TopicConfigManager.scala
b675a7e45ea4f4179f8b15fe221fd988aff13aa0
core/src/main/scala/kafka/tools/ConsoleConsumer.scala
bba39904c5ce896c2d0b9a5c6a55135092862dcd
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala
d2bac85e16a247b1326f63619711fb0bbbd2e82a
core/src/main/scala/kafka/tools/ExportZkOffsets.scala
ce14bbc7f00b3af6818512bd8485da985b1c478c
core/src/main/scala/kafka/tools/ImportZkOffsets.scala
598350d718162fb791be8ec992b83d7cd33cf41c
core/src/main/scala/kafka/tools/MirrorMaker.scala
954852170d67cbb8ff4f113301816d2a2daf5e91
core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala
9235ed9c3a393f26dc19fe0d4e18cfb35bf2af06
core/src/main/scala/kafka/tools/VerifyConsumerRebalance.scala
4fb519bf6d00cd81013e9ca6d7fa6e4e8d1bb1a6
core/src/main/scala/kafka/utils/CoreUtils.scala
d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/main/scala/kafka/utils/ReplicationUtils.scala
60687332b4c9bee4d4c0851314cfb4b02d5d3489
core/src/main/scala/kafka/utils/ZkUtils.scala
2618dd39b925b979ad6e4c0abd5c6eaafb3db5d5
core/src/main/scala/kafka/utils/timer/Timer.scala
b8cde820a770a4e894804f1c268b24b529940650
core/src/main/scala/kafka/utils/timer/TimerTask.scala
3407138115d579339ffb6b00e32e38c984ac5d6e
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala
e7a96570ddc2367583d6d5590628db7e7f6ba39b
core/src/main/scala/kafka/utils/timer/TimingWheel.scala
e92aba3844dbf3372182e14536a5d98cf3366d73
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala
5c4cca653b3801df3494003cc40a56ae60a789a6
core/src/test/scala/integration/kafka/api/ConsumerTest.scala
a1eed965a148eb19d9a6cefbfce131f58aaffc24
core/src/test/scala/integration/kafka/api/FixedPortTestUtils.scala
1d31a4397e4d4f087b12bc8c6c1685f49d3a8f0e
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
07b1ff47bfc3cd3f948c9533c8dc977fa36d996f
core/src/test/scala/integration/kafka/api/ProducerBounceTest.scala
c9d16bb6b851639683bf72e5f3a4dd65b0671cf4
core/src/test/scala/other/kafka/DeleteZKPath.scala
33c3ef883c9398d5704db9133010c0c83565fa38
core/src/test/scala/other/kafka/StressTestLog.scala
c0e248d669c7bd653f512af7f72d895c38772f83
core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala
3034c4f9b0d026e25ce045689d9a9f99a59a10ec
core/src/test/scala/other/kafka/TestOffsetManager.scala
9881bd3dff0591f315bd53aea96d3c6e12a24cb6
core/src/test/scala/unit/kafka/KafkaConfigTest.scala
bc4aef31940b7ab896bd0a5559a3a63d9f7de915
core/src/test/scala/unit/kafka/admin/AdminTest.scala
efb2f8e79b3faef78722774b951fea828cd50374
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala PRE-CREATION
core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
c7136f20972614ac47aa57ab13e3c94ef775a4b7
core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala
bb2506ca186bb2e5a606263fb0c50ae95769ff68
core/src/test/scala/unit/kafka/common/ConfigTest.scala
7bff96caca1dc715a81b48cec84cb3c163f7faa3
core/src/test/scala/unit/kafka/common/TopicTest.scala
0fb25880c24adef906cd06359b624e7c8eb94ca6
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala
1910fcbfb4353fa6adba0ba125c49f1aa8132770
core/src/test/scala/unit/kafka/consumer/TopicFilterTest.scala
4f124af5c3e946045a78ad1519c37372a72c8985
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala
7f9fca3475dd1e74252a4ae686a62133f6ca3127
core/src/test/scala/unit/kafka/coordinator/ConsumerCoordinatorResponseTest.scala
PRE-CREATION
core/src/test/scala/unit/kafka/coordinator/CoordinatorMetadataTest.scala
08854c5e6ec249368206298b2ac2623df18f266a
core/src/test/scala/unit/kafka/integration/MinIsrConfigTest.scala
70a5b3aa00a1f647f23ad353b8b1fb1ece020505
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
995b05901491bb0dbf0df210d44bd1d7f66fdc82
core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala
375555f0684bbd0bfaf64b765ce04a928e257f0a
core/src/test/scala/unit/kafka/log/CleanerTest.scala
8b8249a35322a60ca94cb385a6cad25943dd1cc9
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala
471ddff9bff1bdfa277c071e59e5c6b749b9c74f
core/src/test/scala/unit/kafka/log/LogConfigTest.scala
f3546adee490891e0d8d0214bef00b1dd7f42227
core/src/test/scala/unit/kafka/log/LogManagerTest.scala
01dfbc4f8d21f6905327cd4ed6c61d657adc0143
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
03fb3512c4a4450eac83d4cd4b0919baeaa22942
core/src/test/scala/unit/kafka/log/LogTest.scala
8e095d652851f05365e1d3bbe3e9e1c3345b7a40
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala
41366a14590d318fced0e83d6921d8035fa882da
core/src/test/scala/unit/kafka/network/SocketServerTest.scala
95d562134c0414ddc3caaa1e1defeb246f585b0b
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala
7877f6ca1845c2edbf96d4a9783a07a552db8f07
core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
528525b719ec916e16f8b3ae3715bec4b5dcc47d
core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala
fe8d2aeb642bc075b65ae19d3c85ef4b3f00104a
core/src/test/scala/unit/kafka/utils/CommandLineUtilsTest.scala
e832a0179c721546abc725d8b1ee5d78fccdad1f
core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala
c96c0ffd958d63c09880d436b2e5ae96f51ead36
core/src/test/scala/unit/kafka/utils/TestUtils.scala
faae0e907596a16c47e8d49a82b6a3c82797c96d
core/src/test/scala/unit/kafka/zk/ZKEphemeralTest.scala
85eec6fa5d09f302d3d8de13e6c68a9e93304ec5
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala
a2d062f725170e2f9453f3bea6a5110f30a1e704
core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala
86bddead8bf9e284eb6a033729a8711885a42495
gradle.properties 90b1945372e767b9c2d0a50df9eb7063e0629952
gradle/buildscript.gradle 5e45c06e8bb8b7c4cb681684023686a7b2252fb7
gradle/license.gradle b4b62ebe277719b28bd131dde9e2a1cdb030e2a9
gradle/rat.gradle PRE-CREATION
gradle/resources/rat-output-to-html.xsl PRE-CREATION
kafka-patch-review.py b5a2e950110d44d20d21e3d72be1783ceb49627d
log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
PRE-CREATION
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
PRE-CREATION
log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java
PRE-CREATION
scala.gradle cabb59c2a6289bc3a2673ddfa3842addf9a5bb44
settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45
system_test/system_test_runner.py 5078d4479fab71722751a28c3c8f5c0f61baadec
topics.json ff011ed381e781b9a177036001d44dca3eac586f
vagrant/broker.sh 63f2d4f30c5a46307d0fe991bbc791a9804b180e
vagrant/zk.sh 15517f826461d8adc2b7b32257cc03d7bfe11bc3
Diff: https://reviews.apache.org/r/34554/diff/
Testing
-------
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar