[ 
https://issues.apache.org/jira/browse/KAFKA-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628928#comment-14628928
 ] 

Geoffrey Anderson commented on KAFKA-2330:
------------------------------------------

+1 from me

I confirmed on my mac that changes in the kafka directory are immediately 
visible within the vm's /vagrant directory, and that aws requires rsync.

Note that the rsync excludes don't work, but this may actually be a problem 
with vagrant-aws: https://github.com/mitchellh/vagrant-aws/issues/304

At first I thought this might be an issue with the variable name 
'vagrant_excludes': the current Vagrant docs show 'vagrant__exclude' (double 
underscore, singular - http://docs.vagrantup.com/v2/synced-folders/rsync.html), 
however you can find both usages in a quick google search, so it's not clear to 
me which if any is incorrect. I did a quick trial of both variable names, and 
neither seems to work.

> Vagrantfile sets global configs instead of per-provider override configs
> ------------------------------------------------------------------------
>
>                 Key: KAFKA-2330
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2330
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.1
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Ewen Cheslack-Postava
>            Priority: Minor
>             Fix For: 0.8.3
>
>         Attachments: KAFKA-2330.patch
>
>
> There's a couple of minor incorrect usages of the global configuration object 
> in the Vagrantfile inside provider-specific override blocks where we should 
> be using the override config object. Two end up being harmless since they 
> have no affect on other providers (but should still be corrected). The third 
> results in using rsync when using Virtualbox, which is unnecessary, slower, 
> and requires copying the entire kafka directory to every VM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to