> On July 16, 2015, 4:53 p.m., Edward Ribeiro wrote: > > core/src/main/scala/kafka/server/OffsetManager.scala, line 454 > > <https://reviews.apache.org/r/36548/diff/1/?file=1013403#file1013403line454> > > > > It looks like there's a mix of "if(" and "if (", with the latter being > > more used than the former. For this reason, I think it would be nice to put > > a space between "if" and parenthesis, and maybe we should open a ticket to > > define and uniform the coding style of the project (if one doesn't exists > > already).
There is a coding guide here: http://kafka.apache.org/coding-guide.html Spaces after if statements is not mentioned. I don't have strong feeling either way. - Grant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36548/#review91898 ----------------------------------------------------------- On July 16, 2015, 2:33 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36548/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 2:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2336 > https://issues.apache.org/jira/browse/KAFKA-2336 > > > Repository: kafka > > > Description > ------- > > KAFKA-2336: Changing offsets.topic.num.partitions after the offset topic is > created breaks consumer group partition assignment > > > Diffs > ----- > > core/src/main/scala/kafka/server/OffsetManager.scala > 47b6ce93da320a565435b4a7916a0c4371143b8a > > Diff: https://reviews.apache.org/r/36548/diff/ > > > Testing > ------- > > > Thanks, > > Grant Henke > >
