[
https://issues.apache.org/jira/browse/KAFKA-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630887#comment-14630887
]
Ismael Juma commented on KAFKA-2344:
------------------------------------
Good point about the reviewers. I noticed that too.
Regarding the second point, the tool does that. You need to set the your JIRA
credentials as per the wiki instructions (the tool also writes a message saying
as much when it exits).
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
> Improvements for the pr-merge tool
> ----------------------------------
>
> Key: KAFKA-2344
> URL: https://issues.apache.org/jira/browse/KAFKA-2344
> Project: Kafka
> Issue Type: Improvement
> Reporter: Gwen Shapira
> Priority: Minor
>
> Two suggestions for the new pr-merge tool:
> * The tool doesn't allow to credit reviewers while committing. I thought the
> review credits were a nice habit of the Kafka community and I hate losing it.
> OTOH, I don't want to force-push to trunk just to add credits. Perhaps the
> tool can ask about committers?
> * Looks like the tool doesn't automatically resolve the JIRA. Would be nice
> if it did.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
