GitHub user jhspaybar opened a pull request:
https://github.com/apache/kafka/pull/86
Addresses Jira Kafka-2236 to eliminate an array index out of bounds eâ¦
â¦xception when segments are appended between checks
First pull request, so if I did this incorrectly, let me know. The
contribution guidelines here http://kafka.apache.org/contributing.html said to
post patch files directly to Jira, but it looked like Github was very active,
but I can post over there as well if preferred. There didn't seem to be
existing unit tests here, and about the only way I could see to add them to
catch this bug and prevent regressions would be quite intrusive. If this is
okay to merge, great! If not due to tests, any tips on how I should go about
testing this would be appreciated(I would think making the function public,
annotate with @VisibleForTesting maybe, and lots of mocks?)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jhspaybar/kafka kafka-2236
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit 1922ae69acba1601d7843ae8d2687ddf70dfc4a6
Author: William Thurston <[email protected]>
Date: 2015-07-19T02:54:05Z
Addresses Jira Kafka-2236 to eliminate an array index out of bounds
exception when segments are appended between checks
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
