> On July 21, 2015, 11:15 p.m., Gwen Shapira wrote: > > Thanks for looking into that. Exception handling was the most challenging > > part of rewriting SocketServer, so I'm glad to see more eyes on this > > implementation. > > > > I have a concern regarding the right way to handle an unexpected exceptions.
Hi Gwen, thanks for the quick review. I replied to your comments below. Mind taking another look? - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36664/#review92496 ----------------------------------------------------------- On July 22, 2015, 5:02 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36664/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 5:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2353 > https://issues.apache.org/jira/browse/KAFKA-2353 > > > Repository: kafka > > > Description > ------- > > Addressed Gwen's comments > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 91319fa010b140cca632e5fa8050509bd2295fc9 > > Diff: https://reviews.apache.org/r/36664/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
