----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36670/#review92688 -----------------------------------------------------------
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line 267) <https://reviews.apache.org/r/36670/#comment146915> I am ambivalent about catching '_', so I decided to let the error propagate. core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala (line 269) <https://reviews.apache.org/r/36670/#comment146916> I disagree because we are issuing two `deleteTopic` operations, the first one should succeed and the second one should fail with an specific exception, but in spite of this the topic should have been deleted by the first call, even if the fail is called. But I am okay with removing the finally block and have it after the catch. - Edward Ribeiro On July 22, 2015, 1:46 a.m., Edward Ribeiro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36670/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 1:46 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2355 > https://issues.apache.org/jira/browse/KAFKA-2355 > > > Repository: kafka > > > Description > ------- > > KAFKA-2355 Add an unit test to validate the deletion of a partition marked as > deleted > > > Diffs > ----- > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > fa8ce259a2832ab86f9dda8c1d409b2c42d43ae9 > > Diff: https://reviews.apache.org/r/36670/diff/ > > > Testing > ------- > > > Thanks, > > Edward Ribeiro > >
