For my part I actually prefer it how it is. The scala code is a different language, has different naming and capitalization conventions, etc. I actually like that it has a different look and feel so I don't get confused. In general, I think 4 spaces is standard for java and 2 spaces is pretty standard for scala (which is often heavily indented).
I do agree that working with a mixture of scala and java is a pain in the butt. What about considering the more extreme idea of just moving the remaining server-side scala into java? I like Scala, but the tooling and compatibility story for java is better, and Java 8 addressed some of the gaps. For a system like Kafka I do kind of think that what Scala offers is less useful, and the kind of boring Java tooling like IDE support, findbugs, checkstyle, simple exception stack traces, and a good compatability story is more important. I suspect a really focused de-scalification effort could eliminate it in a couple of weeks if we didn't try to do anything else at the same time. I think if this was done module-by-module with close review to avoid introducing bugs this might not be doable. There are a couple things you'd have to wait for for this to work: - Finish some of the testing improvements so we can feel confident we aren't introducing bugs - Wait for java 8 to become common so we don't have to translate to java 7 - Wait until we are ready to deprecate the old scala clients (older versions would still work against the server but we wouldn't release new ones). Even ignoring those items I don't think we would dare take this on right now because there are so many other projects in flight but it might be worth thinking about in 9 months or so. -Jay On Thu, Jul 23, 2015 at 5:43 PM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > Hey everyone, > > I was wondering if it is possible to standardize indentation across clients > and core. As an example, all the java code uses 4 spaces and the scala code > 2. As we increasingly share code between clients and core, I think > consistency would be super useful. > > Thoughts? > > Aditya >
