Ewen, This is quite useful. I used the command that is suggested in the ASFBot comment:
git pull https://github.com/[contribuer-name]/kafka KAFKA-xxxx to apply the patch locally. But this would actually better I think, just that it requires installing hub first. Maybe we can add this to the wiki as well? Guozhang On Thu, Jul 23, 2015 at 9:32 PM, Ewen Cheslack-Postava <e...@confluent.io> wrote: > +1 (non-binding) > > One other thing that might be worth mentioning in "The Review Process" > section is the hub tool: https://hub.github.com/ I only ever use one > feature, but it's immensely useful if you're reviewing PRs on Github. You > can just copy the URL into a command to checkout the PR branch: > > hub checkout https://github.com/apache/kafka/pull/95 > > -Ewen > > > On Wed, Jul 22, 2015 at 1:26 PM, Ismael Juma <ism...@juma.me.uk> wrote: > > > Hi, > > > > On 22 Jul 2015 19:32, "Jiangjie Qin" <j...@linkedin.com.invalid> wrote: > > > > > > +1 (non binding) > > > > > > Can we have a wiki for procedure and let people verify the steps? After > > > that we can update the Apache project page. > > > > Yes, I linked to the page in the original message: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > > > > Committers and contributors have provided feedback in previous > discussions > > in the mailing list. Further improvements are welcome, of course. > > > > Also see KAFKA-2321 and KAFKA-2349 for updates to the website and > GitHub's > > CONTRIBUTING.md. > > > > Ismael > > > > > > -- > Thanks, > Ewen > -- -- Guozhang
