[
https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642400#comment-14642400
]
Ewen Cheslack-Postava commented on KAFKA-2100:
----------------------------------------------
LGTM.
wrt inconsistency: the example shown, canRetry, checks RetriableException. This
info isn't available directly via the error code. It's true we could make the
error checking consistent and convert to Error as needed to check the exception
type, but this doesn't strike me as particularly egregious. I wouldn't worry
about it.
> Client Error doesn't preserve or display original server error code when it
> is an unknown code
> ----------------------------------------------------------------------------------------------
>
> Key: KAFKA-2100
> URL: https://issues.apache.org/jira/browse/KAFKA-2100
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Gwen Shapira
> Assignee: David Jacot
> Labels: newbie
> Attachments: KAFKA-2100-1.patch, KAFKA-2100-2.patch
>
>
> When the java client receives an unfamiliar error code, it translates it into
> UNKNOWN(-1, new UnknownServerException("The server experienced an unexpected
> error when processing the request"))
> This completely loses the original code, which makes troubleshooting from the
> client impossible.
> Will be better to preserve the original code and write it to the log when
> logging the error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
