[ 
https://issues.apache.org/jira/browse/KAFKA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654596#comment-14654596
 ] 

ASF GitHub Bot commented on KAFKA-2340:
---------------------------------------

GitHub user hachikuji opened a pull request:

    https://github.com/apache/kafka/pull/112

    KAFKA-2340; improve KafkaConsumer Fetcher test coverage

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hachikuji/kafka KAFKA-2340

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit d6424e566f20d521f535d0116af5bcd50ff1f249
Author: Jason Gustafson <ja...@confluent.io>
Date:   2015-08-05T00:40:25Z

    KAFKA-2340; improve KafkaConsumer Fetcher test coverage

----


> Add additional unit tests for new consumer Fetcher
> --------------------------------------------------
>
>                 Key: KAFKA-2340
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2340
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Jason Gustafson
>
> There are a number of cases in Fetcher which have no corresponding unit 
> tests. To name a few:
> - list offset with partition leader unknown
> - list offset disconnect
> - fetch disconnect
> Additionally, updateFetchPosition (which was moved from KafkaConsumer) has no 
> tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to