> On July 17, 2015, 5:03 a.m., Gwen Shapira wrote: > > Just realized that verifyAssigment runs on a Map of <Partition, Status> and > > originally printed status for each partition (some can succeed, fail or be > > in-progress). > > > > We need to return a single error code. In the existing code, we return 0 if > > all partitions were successfull, 1 if one or more failed, 2 if one of more > > is in progress. If some are in-progress and some are failed, it seems like > > the return value is either 1 or 2, at random (since it depends on order of > > foreach on a Map). > > > > I'm not sure thats expected :) > > > > Perhaps we can come up with something better defined?
Actually return value is not random. If some are in-progress and some are failed, we are returning failed error code. Re-asginment failed status is given more preference than in-progress error status. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92024 ----------------------------------------------------------- On Aug. 5, 2015, 3:19 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34641/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 3:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2214 > https://issues.apache.org/jira/browse/KAFKA-2214 > > > Repository: kafka > > > Description > ------- > > Addresing ismail juma's comments > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > ea345895a52977c25bff57e95e12b8662331d7fe > > Diff: https://reviews.apache.org/r/34641/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
