[ 
https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658594#comment-14658594
 ] 

ASF GitHub Bot commented on KAFKA-2407:
---------------------------------------

GitHub user granthenke opened a pull request:

    https://github.com/apache/kafka/pull/115

    KAFKA-2407: Only create log directory when it will be used

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/granthenke/kafka log-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 49a8dd4218b47978f0210c4e6ec0100aadaf3c21
Author: Grant Henke <granthe...@gmail.com>
Date:   2015-08-05T17:37:07Z

    KAFKA-2407: Only create log directory when it will be used

----


> Only create a log directory when it will be used
> ------------------------------------------------
>
>                 Key: KAFKA-2407
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2407
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2.1
>            Reporter: Grant Henke
>            Assignee: Grant Henke
>             Fix For: 0.8.3
>
>
> Currently kafka-run-class.sh will default the $LOG_DIR and create the 
> directory regardless of it's use. This can cause permissions issues depending 
> on what users are utilizing tools such as kafka-topics.sh.
> Further down in the script there is logic to detect whether $KAFKA_LOG4J_OPTS 
> is set. If it is not set this is assumed to be a tool call and the script 
> sets tools-log4j.properties which only uses the console appender. In this 
> scenario a logging directory is not needed. In all other cases 
> $KAFKA_LOG4J_OPTS will be set and we can move the $LOG_DIR defaulting & 
> creation logic there. For example kafka-server-start.sh sets 
> $KAFKA_LOG4J_OPTS to use its own log4j.properties file which respects the 
> $LOG_DIR/kafka.log4j.dir setting. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to