Yes, that page is crystal clear that we are using PR only :) Jiangjie (Becket) Qin
On Wed, Aug 5, 2015 at 10:56 AM, Gwen Shapira <g...@confluent.io> wrote: > The sentence is good, but I think we route new developers to here: > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes > > Can you check if this page makes it clear that we take PRs and PRs only? > > Gwen > > On Wed, Aug 5, 2015 at 10:36 AM, Jiangjie Qin <j...@linkedin.com.invalid> > wrote: > > > Hi Gwen, > > > > I just added one sentence saying we would prefer PR for new patches. Let > me > > know if you think it is too verbose. > > > > Thanks, > > > > Jiangjie (Becket) Qin > > > > On Wed, Aug 5, 2015 at 8:57 AM, Gwen Shapira <g...@confluent.io> wrote: > > > > > Completely agree! Thank you for reviewing and improving. > > > > > > > > > > > > > > > > > > On Wed, Aug 5, 2015 at 7:22 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > > > > > > Hi Gwen, > > > > > > > > I moved some text from > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review > > > > to > https://cwiki.apache.org/confluence/display/KAFKA/Patch+Review+Tool > > > and > > > > made a few other minor tweaks. I think it's even clearer this way. > > Please > > > > let me know if you disagree. > > > > > > > > Thanks, > > > > Ismael > > > > > > > > > >
