> On Aug. 11, 2015, 10:08 p.m., Gwen Shapira wrote: > > Ship It!
Jiangjie, I commited despite your concerns since this patch fixes a huge potential issue. If you have an idea for an improved fix, we can tackle this in a follow up. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36548/#review95012 ----------------------------------------------------------- On Aug. 11, 2015, 3:37 p.m., Grant Henke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36548/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 3:37 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2336 > https://issues.apache.org/jira/browse/KAFKA-2336 > > > Repository: kafka > > > Description > ------- > > KAFKA-2336: Changing offsets.topic.num.partitions after the offset topic is > created breaks consumer group partition assignment > > > Diffs > ----- > > core/src/main/scala/kafka/server/OffsetManager.scala > 47b6ce93da320a565435b4a7916a0c4371143b8a > > Diff: https://reviews.apache.org/r/36548/diff/ > > > Testing > ------- > > > Thanks, > > Grant Henke > >
