[
https://issues.apache.org/jira/browse/KAFKA-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698177#comment-14698177
]
ASF GitHub Bot commented on KAFKA-2072:
---------------------------------------
GitHub user dajac opened a pull request:
https://github.com/apache/kafka/pull/141
KAFKA-2072 [WIP]: Add StopReplica request/response to o.a.k.common.requests
and replace the usage in core module
Migration is done but this PR will need to be rebased on #110. I have
copied some code (ef669a5) for now.
I'd appreciate feedback on it mainly around how I handle things in the
ControllerChannelManager. I have introduced a new 'sendRequest' method for
o.a.k.common.requests and kept the old one for compatibility reason. We'll be
able to remove the old one in the future when migration of all requests and
responses to o.a.k.common.requests is completed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dajac/kafka KAFKA-2072
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit 22f2466f985cde1787a41f13a0191a538fc3a23f
Author: David Jacot <david.ja...@gmail.com>
Date: 2015-08-13T15:36:49Z
Add o.a.k.c.r.StopReplicaRequest and o.a.k.c.r.StopReplicaResponse.
commit 3a31ba9dc3d912e91535cf3a4e373b8f56b347b4
Author: David Jacot <david.ja...@gmail.com>
Date: 2015-08-13T17:15:18Z
Replace k.a.StopReplicaRequest and k.a.StopReplicaResponse in KafkaApis by
their org.apache.kafka.common.requests equivalents.
commit ef669a5ff5fc125624d5d1ec79b92940d43ca3bb
Author: David Jacot <david.ja...@gmail.com>
Date: 2015-08-14T18:42:37Z
Code cherry-picked from KAFKA-2071. It can be removed when KAFKA-2071 is
merged.
commit cbaa987385d989fad8cc3f40d50a24c2ee25ae78
Author: David Jacot <david.ja...@gmail.com>
Date: 2015-08-14T18:46:21Z
Replace k.a.StopReplicaRequest and k.a.StopReplicaResponse in Controller by
their org.apache.kafka.common.requests equivalents.
commit 48a05d81c94ca30fff96df8c82587e64db4260b0
Author: David Jacot <david.ja...@gmail.com>
Date: 2015-08-14T18:53:32Z
Remove k.a.StopReplicaRequest and k.a.StopReplicaResponse.
----
> Add StopReplica request/response to o.a.k.common.requests and replace the
> usage in core module
> ----------------------------------------------------------------------------------------------
>
> Key: KAFKA-2072
> URL: https://issues.apache.org/jira/browse/KAFKA-2072
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Gwen Shapira
> Assignee: David Jacot
> Fix For: 0.8.3
>
>
> Add StopReplica request/response to o.a.k.common.requests and replace the
> usage in core module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
