-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36578/#review95943
-----------------------------------------------------------



core/src/main/scala/kafka/admin/TopicCommand.scala (line 89)
<https://reviews.apache.org/r/36578/#comment151144>

    The warning message can be : "WARNING: %s has been increased beyond the 
default max value of %d, update producer and consumer settings as well"


Also do want to include patch for second point given in JIRA decription..

- Manikumar Reddy O


On July 21, 2015, 4:21 p.m., Edward Ribeiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36578/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 4:21 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2338
>     https://issues.apache.org/jira/browse/KAFKA-2338
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-2338 Warn users if they change max.message.bytes that they also need to 
> update broker and consumer settings
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/TopicCommand.scala 
> 4e28bf1c08414e8e96e6ca639b927d51bfeb4616 
> 
> Diff: https://reviews.apache.org/r/36578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Edward Ribeiro
> 
>

Reply via email to