GitHub user ijuma reopened a pull request: https://github.com/apache/kafka/pull/151
KAFKA-2411; remove usage of blocking channel You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-2411-remove-usage-of-blocking-channel Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 ---- commit dbcde7e828a250708752866c4610298773dea006 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-19T13:30:35Z Introduce `ChannelBuilders.create` and use it in `ClientUtils` and `SocketServer` commit 6de8b9b18c6bfb67e72a4fccc10768dff15098f8 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-19T14:22:55Z Use `Selector` instead of `BlockingChannel` for controlled shutdown commit da7a980887ab2b5d007ddf80c3059b6619d52f99 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-19T14:23:11Z Use `Selector` instead of `BlockingChannel` in `ControllerChannelManager` commit 2b258901929e24fce2329bc85e650e4ca022bca0 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-20T11:10:53Z Move `readCompletely` from `NetworkReceive` to `BlockingChannel` It is now a private method since it's not used anywhere else and it's been changed slightly to match the use-case better. commit f804f633d93d2beea94017bba9225504c2f9cea4 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-20T12:29:55Z Adjust buffer and max request size to match `BlockingChannel` behaviour Based on feedback from Gwen. commit c71aab9b6e4c6172615a125d2406ff6f3d668996 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-20T12:53:39Z Introduce specific methods in `SelectorUtils` and make the generic ones private As suggested by Gwen. commit 1de16166232e0b9a4b0798de493869d3ce23964c Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-20T13:17:45Z Reuse `Selector` when removing and re-adding brokers in `ControllerChannelManager` As suggested by Gwen. commit bf5b9c81fa59efa2429a409d3872f4f6f0d5d589 Author: Ismael Juma <ism...@juma.me.uk> Date: 2015-08-20T14:55:03Z Merge remote-tracking branch 'apache/trunk' into kafka-2411-remove-usage-of-blocking-channel * apache/trunk: KAFKA-2330: Vagrantfile sets global configs instead of per-provider override configs; patched by Ewen Cheslack-Postava, reviewed by Geoff Anderson and Gwen Shapira KAFKA-2246; Fix incorrect config ZK path. KAFKA-2084; trivial follow-up (remove JUnit3Suite dependency) ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---