----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review96061 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala (line 264) <https://reviews.apache.org/r/36652/#comment151266> Thanks for the reference - we currently have this pattern all over the place. We can keep what you have, but this should probably become a utility say `CoreUtils.catchThrowable` (similar to `CoreUtils.swallow*`) core/src/main/scala/kafka/network/SocketServer.scala (line 265) <https://reviews.apache.org/r/36652/#comment151267> Yes, but we don't need to do that now. - Joel Koshy On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36652/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 8:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2351 > https://issues.apache.org/jira/browse/KAFKA-2351 > > > Repository: kafka > > > Description > ------- > > Added a try-catch to catch any exceptions thrown by the nioSelector > > > Addressed comments on the Jira ticket > > > Addressed Jun's comments > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > dbe784b63817fd94e1593136926db17fac6fa3d7 > > Diff: https://reviews.apache.org/r/36652/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
