[ 
https://issues.apache.org/jira/browse/KAFKA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707491#comment-14707491
 ] 

ASF GitHub Bot commented on KAFKA-2442:
---------------------------------------

GitHub user auradkar opened a pull request:

    https://github.com/apache/kafka/pull/160

    KAFKA-2442: Fixing transiently failing test

    Made the following changes:
    1. Made the quotas very small. (100 and 10 bytes/sec for producer and 
consumer respectively)
    2. For the producer, I'm asserting the throttle_time with a timed loop 
using waitUntilTrue
    3. For the consumer, I'm simply calling a timed poll in a loop until the 
server side throttle time metric returns true

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/auradkar/kafka failing-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #160
    
----
commit cd60472049dee0f515d4fc3f87bc1d6bba1eb923
Author: Aditya Auradkar <aaurad...@linkedin.com>
Date:   2015-08-21T21:21:51Z

    KAFKA-2442: Fixing transiently failing test

----


> QuotasTest should not fail when cpu is busy
> -------------------------------------------
>
>                 Key: KAFKA-2442
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2442
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Dong Lin
>            Assignee: Aditya Auradkar
>             Fix For: 0.8.3
>
>
> We observed that testThrottledProducerConsumer in QuotasTest may fail or 
> succeed randomly. It appears that the test may fail when the system is slow. 
> We can add timer in the integration test to avoid random failure.
> See an example failure at 
> https://builds.apache.org/job/kafka-trunk-git-pr/166/console for patch 
> https://github.com/apache/kafka/pull/142.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to